Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for maven-badges.herokuapp #363

Closed
vedran-kasalica opened this issue Nov 17, 2023 · 2 comments
Closed

Support for maven-badges.herokuapp #363

vedran-kasalica opened this issue Nov 17, 2023 · 2 comments

Comments

@vedran-kasalica
Copy link
Contributor

vedran-kasalica commented Nov 17, 2023 •
edited
Loading

I have Step "(3/5) registry" failing because the check failed to recognise a badge generated using maven-badges.herokuapp project. See my badge here.

This could be easily fixed by adding support for the herokuapp format.
@vedran-kasalica vedran-kasalica mentioned this issue Nov 17, 2023
Merged
@jspaaks
Copy link
Member

jspaaks commented Nov 27, 2023

Hi Vedran, thanks for making the issue. Note that howfairis development is on hold for the moment, so this might not be implemented soon

@vedran-kasalica
Copy link
Contributor Author

Hi Jurriaan, thanks for the reply. I opened PR #364 with a fix (it was a small change), but I understand that it might require time to review it.
Cheers

@fdiblen fdiblen closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fdiblen @jspaaks @vedran-kasalica