Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that OpenSSF badges are recognized #359

Closed
jspaaks opened this issue Sep 13, 2022 · 5 comments
Closed

check that OpenSSF badges are recognized #359

jspaaks opened this issue Sep 13, 2022 · 5 comments

Comments

@jspaaks
Copy link
Member

jspaaks commented Sep 13, 2022

Core Infrastructures project changed its name, might have broken the correct idnetification of these badges

@fdiblen
Copy link
Member

fdiblen commented Sep 13, 2022

Looks like the url for badges are the same.
See https://github.com/coreinfrastructure/best-practices-badge for an example.

This is same as what we have for checklist regex:

regexes = [r"https://bestpractices\.coreinfrastructure\.org/projects/[0-9]*/badge"]

@benvanwerkhoven
Copy link
Contributor

Can confirm, I just added the OpenSSF badge to Kernel Tuner. It is correctly recognized by howfairis.

@mattkretz
Copy link
Contributor

I confirm the name change broke new badges. Existing badges with the old URL continue to work (as badge, link, and getting recognized by howfairis). However, the latest badge I pasted into a README.md is not recognized:

[![OpenSSF Best Practices](https://www.bestpractices.dev/projects/9447/badge)](https://www.bestpractices.dev/projects/9447)

I have a PR ready to resolve this issue, but the contribution guidelines require to discuss here first.

@mattkretz
Copy link
Contributor

ping @c-martinez OK if I submit a PR for this as well? (aecb9c3)

@c-martinez
Copy link
Contributor

Yes, please @mattkretz ! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants