Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nibble code doesn't check data epilog bytes #69

Open
fadden opened this issue Oct 4, 2023 · 0 comments
Open

Nibble code doesn't check data epilog bytes #69

fadden opened this issue Oct 4, 2023 · 0 comments
Labels

Comments

@fadden
Copy link
Owner

fadden commented Oct 4, 2023

The DiskImg::NibbleDescr struct has a dataEpilogVerifyCount field, but it's never actually used. This omission allows the "standard" profile to read some disks that it shouldn't (e.g. MECC).

Not really a problem, especially since the auto-detection would just switch to the "patched" profile (which explicitly skips checking the epilogs), but the behavior tells the user that the disk has a standard format when it doesn't.

@fadden fadden added the bug label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant