upstream static #807
Open
upstream static #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
ipiszy
reviewed
Jul 24, 2023
static/csrc/model_container.cpp
Outdated
| @@ -403,9 +403,9 @@ void ModelContainer::SetConstantImpl( | |||
| ". Check that the provided tensor's shape is correct."); | |||
| } | |||
| } else { | |||
| throw std::runtime_error( | |||
There was a problem hiding this comment.
Why this change? We want to throw an error in this case?
There was a problem hiding this comment.
Maybe there are some additional variables won't be loaded to the ait model, only warning them is a better solution.
There was a problem hiding this comment.
Do you have any examples? This error means that a constant is neither bound nor unbound, which is unexpected. It means that there is something wrong in this constant.
|
Thanks @fsx950223 ! |
|
Any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @ipiszy