skip fusing slice with a strided op if the relevant tensor accessors are already set #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47028458 |
…are already set (facebookincubator#799) Summary: Pull Request resolved: facebookincubator#799 In some cases, when we fuse a slice op with a strided op (e.g. concat), the relevant tensor accessors in the strided op's input tensors may have already be updated. Let's skip fusion in such a case. Note that technically, we might be able to perform fusion in some senarios, but let's handle those later if we see needs. Differential Revision: D47028458 fbshipit-source-id: 5e3eab0531ef539c61c384d9e051bdfb75683948
chenyang78
force-pushed
the
export-D47028458
branch
from
51bc731
to
d5842ac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47028458 |
|
This pull request has been merged in 5e30494. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In some cases, when we fuse a slice op with a strided op (e.g. concat), the
relevant tensor accessors in the strided op's input tensors may have already
be updated. Let's skip fusion in such a case.
Note that technically, we might be able to perform fusion in some senarios,
but let's handle those later if we see needs.
Differential Revision: D47028458