skip fusing slice with a strided op if the relevant tensor accessors … #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are already set In some cases, when we fuse a slice op with a strided op (e.g. concat), the relevant tensor accessors in the strided op's input tensors may have already be updated. Let's skip fusion in such a case. Note that technically, we might be able to perform fusion in some senarios, but let's handle those later if we see needs.
facebook-github-bot
added
the
CLA Signed
|
@chenyang78 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Seems something went wrong. Closing this PR first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…are already set
In some cases, when we fuse a slice op with a strided op (e.g. concat), the relevant tensor accessors in the strided op's input tensors may have already be updated. Let's skip fusion in such a case.
Note that technically, we might be able to perform fusion in some senarios, but let's handle those later if we see needs.