Add test cases to cover split_large_slice_scatter
#794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The existing tests don't use the `slice_reshape_scatter` op, so the `split_large_slice_scatter` logic is not tested. If we remove `split_large_slice_scatter` from `optimize_graph`, the existing tests can still pass. The newly added test cases would fail without `split_large_slice_scatter`. Differential Revision: D46770757 fbshipit-source-id: 4b63a9d409af13fc96479278dd42ba7f0092f626
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46770757 |
|
This pull request has been merged in dccb361. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The existing tests don't use the
slice_reshape_scatterop, so thesplit_large_slice_scatterlogic is not tested.If we remove
split_large_slice_scatterfromoptimize_graph, the existing tests can still pass.The newly added test cases would fail without
split_large_slice_scatter.Differential Revision: D46770757