Add max_acc_splits #1017
Closed
Add max_acc_splits #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60133589 |
|
This pull request was exported from Phabricator. Differential Revision: D60133589 |
qxy11
force-pushed
the
export-D60133589
branch
from
b299d6b
to
32aef68
Compare
qxy11
added a commit
to qxy11/AITemplate-1
that referenced
this pull request
Aug 12, 2024
Summary: Pull Request resolved: facebookincubator#1017 X-link: pytorch/pytorch#133041 Model owners can set the lower_settings with max_acc_splits=2, and lowering will fail during model iteration, to alert them of possible performance degradation from increased fragmentation. Differential Revision: D60133589
qxy11
added a commit
to qxy11/pytorch
that referenced
this pull request
Aug 12, 2024
Summary: X-link: facebookincubator/AITemplate#1017 Pull Request resolved: pytorch#133041 Model owners can set the lower_settings with max_acc_splits=2, and lowering will fail during model iteration, to alert them of possible performance degradation from increased fragmentation. Test Plan: Added unit tests Differential Revision: D60133589
|
This pull request was exported from Phabricator. Differential Revision: D60133589 |
qxy11
added a commit
to qxy11/AITemplate-1
that referenced
this pull request
Aug 12, 2024
Summary: Pull Request resolved: facebookincubator#1017 X-link: pytorch/pytorch#133041 Model owners can set the lower_settings with max_acc_splits=2, and lowering will fail during model iteration, to alert them of possible performance degradation from increased fragmentation. Reviewed By: frank-wei Differential Revision: D60133589
qxy11
force-pushed
the
export-D60133589
branch
from
32aef68
to
3d28a5e
Compare
qxy11
added a commit
to qxy11/pytorch
that referenced
this pull request
Aug 12, 2024
Summary: X-link: facebookincubator/AITemplate#1017 Pull Request resolved: pytorch#133041 Model owners can set the lower_settings with max_acc_splits=2, and lowering will fail during model iteration, to alert them of possible performance degradation from increased fragmentation. Test Plan: Added unit tests Reviewed By: frank-wei Differential Revision: D60133589
|
This pull request was exported from Phabricator. Differential Revision: D60133589 |
qxy11
added a commit
to qxy11/AITemplate-1
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebookincubator#1017 X-link: pytorch/pytorch#133041 Model owners can set the lower_settings with max_acc_splits=2, and lowering will fail during model iteration, to alert them of possible performance degradation from increased fragmentation. Reviewed By: frank-wei Differential Revision: D60133589
qxy11
force-pushed
the
export-D60133589
branch
from
3d28a5e
to
96d2f06
Compare
qxy11
added a commit
to qxy11/pytorch
that referenced
this pull request
Aug 13, 2024
Summary: X-link: facebookincubator/AITemplate#1017 Pull Request resolved: pytorch#133041 Model owners can set the lower_settings with max_acc_splits=2, and lowering will fail during model iteration, to alert them of possible performance degradation from increased fragmentation. Test Plan: Added unit tests Reviewed By: frank-wei Differential Revision: D60133589
qxy11
added a commit
to qxy11/AITemplate-1
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebookincubator#1017 X-link: pytorch/pytorch#133041 Model owners can set the lower_settings with max_acc_splits=2, and lowering will fail during model iteration, to alert them of possible performance degradation from increased fragmentation. Reviewed By: frank-wei, oniononion36 Differential Revision: D60133589
qxy11
force-pushed
the
export-D60133589
branch
from
96d2f06
to
50f2f9e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60133589 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D60133589 |
qxy11
added a commit
to qxy11/AITemplate-1
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebookincubator#1017 X-link: pytorch/pytorch#133041 Model owners can set the lower_settings with max_acc_splits=2, and lowering will fail during model iteration, to alert them of possible performance degradation from increased fragmentation. Reviewed By: frank-wei, oniononion36 Differential Revision: D60133589
qxy11
force-pushed
the
export-D60133589
branch
from
50f2f9e
to
04240f1
Compare
hl475
approved these changes
Aug 13, 2024
Summary: Pull Request resolved: facebookincubator#1017 X-link: pytorch/pytorch#133041 Model owners can set the lower_settings with max_acc_splits=2, and lowering will fail during model iteration, to alert them of possible performance degradation from increased fragmentation. Reviewed By: frank-wei, oniononion36 Differential Revision: D60133589
|
This pull request was exported from Phabricator. Differential Revision: D60133589 |
qxy11
force-pushed
the
export-D60133589
branch
from
04240f1
to
7a21fa8
Compare
|
This pull request has been merged in 4360ae3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Model owners can set the lower_settings with max_acc_splits=2, and lowering will fail during model iteration, to alert them of possible performance degradation from increased fragmentation.
Differential Revision: D60133589