Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "Should have a queue. This is likely a bug in React" #30038

Open
Nantris opened this issue Jun 21, 2024 · 7 comments
Open

Bug: "Should have a queue. This is likely a bug in React" #30038

Nantris opened this issue Jun 21, 2024 · 7 comments
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@Nantris
Copy link

Nantris commented Jun 21, 2024

React version: 18.2.0

(18.2.0 is required by Expo, but theoretically equivalent to 18.3.1 for this purpose)

Steps To Reproduce

  1. Unknown. No rules of hooks are being broken and the error stack is not helpful for diagnosis.

Code example:

I don't know how to reproduce this. Originally I faced #22049, supposedly caused by our "problem hook":

// Supposed problem hook
const linkableRef = useRef(linkable);
useEffect(() => {
  linkableRef.current = linkable; // linkable is an array of objects
  const { current: editor } = editorRef;
  if (editor) editor.commands.updateLinkable();
}, [linkable, editorRef]);

and removing the hook causes this instead: Error: Should have a queue. This is likely a bug in React. Please file an issue.

The current behavior

Using our simple hook causes #22049 - and removing our hook causes this issue instead

The expected behavior

Using React as specified in the docs causes no errors

@Nantris
Copy link
Author

Nantris commented Jun 22, 2024

This occurs ONLY on the first instance of taking the "problematic action" that causes the bug, and only if take on the the first mount of the problem component.

Identical actions after this crash has occurred and the component is re-mounted via the ErrorBoundary will not produce any errors. Loading the component a second time (different props of the same sort) also prevents this issue from occurring.

This extremely strange circumstance is making debugging unrelated issues quite difficult.

@Nantris
Copy link
Author

Nantris commented Jun 23, 2024

This is really plaguing us. I hope this can be resolved.

@Nantris
Copy link
Author

Nantris commented Jun 25, 2024

Friendly bump. I know this seems like impatience but an unmitigatable bug in React is a big problem for us.

@eps1lon
Copy link
Collaborator

eps1lon commented Jun 26, 2024

Calling hooks conditionally usually leads to these kind of bugs. If you want help fixing this issue, we need a minimal reproduction.

@Nantris
Copy link
Author

Nantris commented Jun 26, 2024

Thanks for your reply @eps1lon. We're 100% not calling hooks conditionally. I manually reviewed the code three times, asked ChatGPT, and ESLint also agrees. Unfortunately I have no idea what code is really causing the problem because commenting out the "problem hook" is what leads to this error. How can I glean any clue about the underlying cause?

I can't share our private code and the error message provides not a single avenue to pursue. It would be a different thing if I knew commenting out some code resolved an issue - but in this case it causes the issue.

@eps1lon
Copy link
Collaborator

eps1lon commented Jun 26, 2024

I'd start by removing surrounding code until it no longer reproduces. It might also be a sibling or parent component that calls hooks conditionally.

@Nantris
Copy link
Author

Nantris commented Jun 27, 2024

Thanks for the advice @eps1lon! I'll see if I can uncover anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

No branches or pull requests

2 participants