You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we are using ProjectivePoint and Scalar directly instead of PublicKey and SecretKey respectively.
The reason was that curve25519_dalek::Scalar supports Zeroize but not ZeroizeOnDrop.
But elliptic_curve::SecretKey supports ZeroizeOnDrop but not Zeroize.
(this was one of the main reasons I worked on introducing ZeroizeOnDrop in the first place)
The best solution here would be to introduce a SecretKey for Ristretto255, which currently doesn't exist, we could introduce this type ourselves in opaque-ke though.
Not sure what to do about elliptic_curve::PublicKey, as it implements neither. Is not zeroing out the public key acceptable?
This is analogous to facebook/voprf#57 and is mainly for code improvement and cleaner deserialization, it doesn't actually change anything.
The text was updated successfully, but these errors were encountered:
Currently we are using
ProjectivePoint
andScalar
directly instead ofPublicKey
andSecretKey
respectively.The reason was that
curve25519_dalek::Scalar
supportsZeroize
but notZeroizeOnDrop
.But
elliptic_curve::SecretKey
supportsZeroizeOnDrop
but notZeroize
.(this was one of the main reasons I worked on introducing
ZeroizeOnDrop
in the first place)The best solution here would be to introduce a
SecretKey
for Ristretto255, which currently doesn't exist, we could introduce this type ourselves inopaque-ke
though.Not sure what to do about
elliptic_curve::PublicKey
, as it implements neither. Is not zeroing out the public key acceptable?This is analogous to facebook/voprf#57 and is mainly for code improvement and cleaner deserialization, it doesn't actually change anything.
The text was updated successfully, but these errors were encountered: