Many tests fail on FreeBSD: Subprocess aborted

[yurivict]

The following tests FAILED:
        818 - */QuicClientTransportIntegrationTest.NetworkTest/* (Subprocess aborted)
        819 - */QuicClientTransportIntegrationTest.FlowControlLimitedTest/* (Subprocess aborted)
        821 - */QuicClientTransportIntegrationTest.TLSAlert/* (Subprocess aborted)
        823 - */QuicClientTransportIntegrationTest.NetworkTestConnected/* (Subprocess aborted)
        824 - */QuicClientTransportIntegrationTest.SetTransportSettingsAfterStart/* (Subprocess aborted)
        825 - */QuicClientTransportIntegrationTest.TestZeroRttSuccess/* (Subprocess aborted)
        826 - */QuicClientTransportIntegrationTest.ZeroRttRetryPacketTest/* (Subprocess aborted)
        827 - */QuicClientTransportIntegrationTest.NewTokenReceived/* (Subprocess aborted)
        828 - */QuicClientTransportIntegrationTest.UseNewTokenThenReceiveRetryToken/* (Subprocess aborted)
        829 - */QuicClientTransportIntegrationTest.TestZeroRttRejection/* (Subprocess aborted)
        830 - */QuicClientTransportIntegrationTest.TestZeroRttNotAttempted/* (Subprocess aborted)
        831 - */QuicClientTransportIntegrationTest.TestZeroRttInvalidAppParams/* (Subprocess aborted)
        832 - */QuicClientTransportIntegrationTest.ChangeEventBase/* (Subprocess aborted)
        833 - */QuicClientTransportIntegrationTest.ResetClient/* (Subprocess aborted)
        834 - */QuicClientTransportIntegrationTest.TestStatelessResetToken/* (Subprocess aborted)
        1294 - ServerHandshakeTest.TestMalformedHandshakeMessage (Subprocess aborted)
        1300 - ServerHandshakeAsyncErrorTest.TestAsyncError (Subprocess aborted)
        1301 - ServerHandshakeAsyncErrorTest.TestCancelOnAsyncError (Subprocess aborted)
        1302 - ServerHandshakeAsyncErrorTest.TestCancelWhileWaitingAsyncError (Subprocess aborted)
        1303 - ServerHandshakeSyncErrorTest.TestError (Subprocess aborted)
Errors while running CTest

mvfst-tests.log

clang-14
OS: FreeBSD 13.1

[kvtsoy]

Does https://github.com/facebook/folly build&test on FreeBSD ok? mvfst depends on it and it seems this is where the failure might be coming from.

[mjoras]

@yurivict yeah, note the logs show that the place failing is this in folly: https://github.com/facebook/folly/blob/main/folly/FBString.h#L310

But we don't use FBString directly and the assert unfortunately isn't giving us a stack trace to see where it's failing.

But my guess is something about FBString isn't quite working as expected on FreeBSD

[yurivict]

Folly is broken: facebook/folly#1867

It uses a class in the std namespace that isn't in any documentation.

[kvtsoy]

Yea unfortunately it looks like there are some folly internals that bsd doesn't like, and mvfst depends on folly.

[yurivict]

folly is generally broken.
No sane compiler would accept std::__vector_base because it isn't defined anywhere, regardless of the system.