fbthrift-compiler.rb

# Copyright (c) Facebook, Inc. and its affiliates.
# All rights reserved.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.

class FbthriftCompiler < Formula
  desc "IDL compiler from Facebook's Thrift, an RPC system"
  homepage "https://github.com/facebook/fbthrift"
  url "https://github.com/facebook/fbthrift/archive/v2017.10.30.00.tar.gz"
  version "2017.10.30.00"
  sha256 "c945e539af960db2ccbe888e5af58791950bf3116b5cffd7ef45ef8d266d7c62"

  head "https://github.com/facebook/fbthrift.git"

  depends_on "autoconf" => :build
  depends_on "automake" => :build
  depends_on "libtool" => :build

  depends_on "glog"
  depends_on "boost"
  depends_on "folly"
  depends_on "mstch"

  # 1. Thrift's configure.ac conflates the cpp runtime with the compiler. Even
  # if we specify `--without-cpp` to skip the checks for e.g. numa which isn't
  # available on OSX, the configure ends up forcing WITH_CPP=true anyway which
  # tries to build the cpp runtime in lib.  We work around that by explicitly
  # removing lib from the list of SUBDIRS to process.
  # 2. The build process for the python chunk of the compiler doesn't really
  # work too well. But that's ok, because it's optional, and the cpp half
  # doesn't know how to call the python half on OSX anyway. So exclude that
  # too.
  # For details, see:
  #  https://github.com/facebook/fbthrift/issues/102
  #  https://github.com/facebook/fbthrift/issues/62
  #  https://github.com/facebook/fbthrift/issues/50
  #  https://github.com/facebook/fbthrift/issues/21
  patch :p1, :DATA

  def install
    cd "thrift" do
      system "autoreconf", "-i"

      system "./configure",
          "--disable-debug",
          "--disable-dependency-tracking",
          "--disable-silent-rules",
          "--prefix=#{prefix}",
          "--without-python", # see patch comment above
          "--without-cpp", # see patch comment above
          "--with-boost=#{HOMEBREW_PREFIX}",
          "--with-folly=#{HOMEBREW_PREFIX}"

      system "make", "install"
    end
  end

  test do
    (testpath/"basic.thrift").write <<-EOF.undent
      enum MyEnum { Val1, Val2 }
      struct MyStruct {
        1: i64 f1,
        2: string f2,
      }
      service MyService {
        string doThing(1: MyStruct arg);
      }
    EOF

    system "#{bin}/thrift1", "-gen", "java", (testpath/"basic.thrift")

    %w[MyEnum.java MyStruct.java MyService.java].each do |file|
      assert (testpath/"gen-java"/file).exist?
    end
  end
end

__END__
--- a/thrift/Makefile.am
+++ b/thrift/Makefile.am
@@ -19,7 +19,7 @@

 ACLOCAL_AMFLAGS = -I m4

-SUBDIRS = compiler lib
+SUBDIRS = compiler


 dist-hook:
--- a/thrift/compiler/Makefile.am
+++ b/thrift/compiler/Makefile.am
@@ -25,8 +25,6 @@ AM_YFLAGS = -d
 LIBS =
 BUILT_SOURCES =

-SUBDIRS = . py
-
 bin_PROGRAMS = thrift1

 noinst_LTLIBRARIES = libparse.la libthriftcompilerbase.la