Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "current version" at the version dropdown redirects to the landing page of docs, which is unintuitive #10206

Open
2 tasks done
axmmisaka opened this issue Jun 10, 2024 · 3 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@axmmisaka
Copy link
Contributor

axmmisaka commented Jun 10, 2024

Have you read the Contributing Guidelines on issues?

Description

Basically title.

If I go to https://docusaurus.io/docs/next/playground and click the "Canary" besides the "English" I will be redirected to https://docusaurus.io/docs/next. This might be a feature but it is unintuitive since clicking "Canary" in the dropdown will result in no behaviour.

Has this been requested on Canny?

No response

Motivation

lf-lang/lf-lang.github.io#235 (comment)

API design

No response

Have you tried building it?

Not yet, but I will try to build it tomorrow and it feels trivial.

Self-service

  • I'd be willing to contribute this feature to Docusaurus myself.
@axmmisaka axmmisaka added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. status: needs triage This issue has not been triaged by maintainers labels Jun 10, 2024
@slorber
Copy link
Collaborator

slorber commented Jun 17, 2024

If I go to docusaurus.io/docs/next/playground and click the "Canary" besides the "English" I will be redirected to docusaurus.io/docs/next.

This is not the behavior I see, please doublecheck

Also this is not a feature request so I'm closing until further details (possibly a video recording?) are provided

@slorber slorber closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
@slorber slorber added bug An error in the Docusaurus core causing instability or issues with its execution closed: can't repro This bug is because of some local setup that can't be reproduced. and removed status: needs triage This issue has not been triaged by maintainers feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. closed: can't repro This bug is because of some local setup that can't be reproduced. labels Jun 17, 2024
@slorber
Copy link
Collaborator

slorber commented Jun 17, 2024

Oh I understand what you mean now. Will have to think about it but maybe we could use the same link for both the dropdown item and the dropdown button.

This might also be confusing if users click it and nothing happens, but we'll see...

@slorber slorber reopened this Jun 17, 2024
@axmmisaka
Copy link
Contributor Author

This might also be confusing if users click it and nothing happens

My $0.02: since it displays the current version, clicking it should lead us to the same destination as if we clicked on the current version in the dropdown, i.e. no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

No branches or pull requests

2 participants