Overture sidebar #1644
Overture sidebar #1644
Conversation
…l Overture inspector.
…it looks like the regular Rapid dataset header.
|
|
||
| /** | ||
| * UiOvertureInspector | ||
| * The OvertureInspector is a UI component for viewing Overture Entities in the sidebar. |
There was a problem hiding this comment.
Love seeing all the documentation, and following the new conventions of using classes and $ for selections makes it easy to see what the code is doing! 👍
|
|
||
| // localize logo | ||
| $inspector.selectAll('.logo-overture > use') | ||
| .attr('xlink:href', `#overture-logo-overture-wordmark${rtl}`); |
There was a problem hiding this comment.
It looks like this code needs to change a little bit for right-to-left.. This is optional and shouldn't hold up the PR.
We could remove the 'src' attribute up on line 87 (in enter selection), and put some code here that sets the 'src' to use either the normal or rtl version of the logo (in update selection).
We'd need to actually make that logo too, but that's easy.
|
|
||
| let key = k; | ||
|
|
||
| // Some params come to us via pmtiles with a prepended '@' sign. |
There was a problem hiding this comment.
Is there a reason why they start with @ ? (I'm new to this and don't know.)
|
|
||
| const $$tagEntry = $$propBag.append('div').attr('class', 'property-entry'); | ||
|
|
||
| if (this._hasJsonStructure(v)) { |
There was a problem hiding this comment.
This is a nit, but the way it's written we are double-parsing everything - once to determine if _hasJsonStructure is true/false, then again to actually get the json. It would be more efficient if _hasJsonStructure was instead _getJson and it would always return the parsed json or maybe {} if it failed.
| @@ -36,6 +36,7 @@ | |||
| "dist:svg:rapid": "svg-sprite --symbol --symbol-dest . --shape-id-generator \"rapid-%s\" --symbol-sprite dist/img/rapid-sprite.svg \"svg/rapid-sprite/**/*.svg\"", | |||
| "dist:svg:roentgen": "svg-sprite --symbol --symbol-dest . --shape-id-generator \"roentgen-%s\" --symbol-sprite dist/img/roentgen-sprite.svg svg/roentgen/*.svg", | |||
| "dist:svg:temaki": "svg-sprite --symbol --symbol-dest . --shape-id-generator \"temaki-%s\" --symbol-sprite dist/img/temaki-sprite.svg node_modules/@rapideditor/temaki/icons/*.svg", | |||
| "dist:svg:overture": "shx cp svg/overture/* dist/img/", | |||
There was a problem hiding this comment.
I think it would be ok to just put the svg into dist/img rather than having this command to copy it over.
Even though our data picker allowed you to show overture places, they weren't interactive at all.
This PR adds hover/select capability to all overture places.
There's a new inspector for the sidebar, UiOvertureInspector.js, which is in charge of rendering the places data. This same rendering code should be broadly applicable to other overture datasets too, I stayed away from any places-specific formatting.
Some custom rendering code to process the PMTiles gets a little gnarly, given that the types we're processing are sometimes a single string, dict of strings, or string array, or dict of string arrays. :-/
Here's what it looks like: