Universal dataset catalog #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had the catalog of Esri datasets, but the Microsoft and Meta datasets were separate from this. As we start offering more sources of data (Microsoft, Meta, Overture, and more?) it would be great to get all the datasets into a single catalog that our users can search through. That's what this commit does! - Introduce `RapidDataset` class to contain all the common props that a dataset needs - Show RapidDatasets in the menus and catalog - Add a lot of methods for working with datasets into RapidSystem - RapidSystem now prepares the catalog at startup - it will getAvailableDatasets from the 3 data-providing services (`mapwithai`,`esri`,`overture`) - This moves a bunch of responsibility around - some things that were in the UI code are now in RapidSystem - some stuff that was duplicated isn't anymore. Still todo: - make sure all the dataset have snippet, itemUrl, thumbnail (only the Esri ones still do) - make sure as datasets get added, they default to a new color (currently they're all magenta)
I'm trying to match the legacy color-choosing behavior from before Rapid#1642 (which changed a bunch of things) This code is a bit weird - I don't like it and we should change it... - If adding fbRoads/msBuildings, choose "Rapid magenta". - If adding an Overture dataset, choose "Overture cyan". - If adding an Esri dataset, choose a color based on how many datasets were added already.
bhousel
force-pushed
the
dataset_catalog
branch
from
c7797c4 to
079ef96
Compare
This gives the added datasets some background grey color and a message like "dataset added", next to the "remove" button
Before they would stay in their spot. Now, adding moves them to the top, removing puts them back in their place.
Most of the datasets are still from ArcGIS, but some will be from Meta, Microsoft, Overture, etc too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while, we've had the catalog of Esri datasets, but the Microsoft and Meta datasets were separate from this.
As we start offering more sources of data (Microsoft, Meta, Overture, and more?) it would be great to get all the datasets into a single catalog that our users can search through. That's what this PR does!
RapidDatasetclass to contain all the common props that a dataset needsmapwithai,esri,overture)Still todo: