Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeskMooovement code review #83

Open
JamesESS opened this issue Nov 14, 2023 · 0 comments
Open

DeskMooovement code review #83

JamesESS opened this issue Nov 14, 2023 · 0 comments

Comments

@JamesESS
Copy link

  • Contrast between text and background not great in places (navbar against pepper on homepage desktop view & search options against courgette)
  • Carousel getting out of alignment on desktop view
  • The month dropdown in my garden is really nice. The month's changing depending on selection is pretty cool I do think it woul be more intuitive if it stayed in calender order the whole time though.
  • Would be good if sign up with preexisting account threw error or just logged in assuming password matched
  • Dyanmic pages should 404 or something to that effect if no data available e.g. search/Apricot currently gives application error. (we need to do this too!)
  • I feel like the pumkins could do with taking up slightly less height on mobile view. using iphone 8 resolution it's not super clear there's more information below
  • Yuqing had issue where homepage searchbar wasn't visible in resized desktop view
  • Site looks fantastic! Mobile view is great
  • File structure is really neat (very jealous of this)
    Most of this is kinda nit picky overall it looks great
    xoxo gossip girl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant