Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cam's comments #54

Open
cameochoquer opened this issue Jul 5, 2023 · 0 comments
Open

Cam's comments #54

cameochoquer opened this issue Jul 5, 2023 · 0 comments

Comments

@cameochoquer
Copy link

  • magic link does not work
  • testApi route does not work
  • I like the 'clean' ui and the + and drop downs I think look intuitive (at least to me!)
  • if you're going for pastel background colour would keep to that and not have the white background for the text as it looks weird
  • I really like the arrows
  • might be worth adding in some lint rules :)
  • Auth set up looks good and is clear
  • I have no idea what this is doing...
  switch (action.type) {
    case "CHANGE_TASK": {
      return {
        ...state,
        projects: state.projects.map(project => {
          if (project.id === action.payload.projectId) {
            return {
              ...project,
              tasks: project.tasks.map(task => {
                if (task.id === action.payload.taskId) {
                  return {
                    ...task,
                    title: action.payload.title,
                    description: action.payload.description,
                  }
                }
                return task
              }),
            }
          }
          return project
        }),
      }
    }
    default: {
      return state
    }
  }
}
  • pref for sign out buttons to look like buttons or some drop down button
  • don't fully understand the need for a dynamic width container? Or why it is named 'componentwithdynamicwidth' why not just issueContainer? or 'textContainer' ? is this a tailwind thing?
  • there are bits where you use react.FC and other places where you import FC from react - I think they're the same but might be worth sticking to one?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant