Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change structure of repo #121

Open
nandantumu opened this issue Mar 5, 2024 · 0 comments
Open

Change structure of repo #121

nandantumu opened this issue Mar 5, 2024 · 0 comments

Comments

@nandantumu
Copy link
Member

Some observation on the code structure (in case we want to change it in this pr):

  • the Track entity does not depend on the gym.Env, so it could make sense to move it outside envs
  • same for the Renderer and all the rendering code.
  • most of the files in the envs implement the simulator. A separation between simulator and gym API might look nice.

I would suggest the following structure:

  • track
  • rendering
  • envs
    • simulator: dynamics_models, collision_models, laser_models, base_classes, etc. (all code that should not depend on the gym)
    • f110_env.py: the actual gym env
    • action: gym implementation of action spaces
    • observation: gym implementation of obs spaces

Originally posted by @luigiberducci in #118 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant