-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Observe SDK support #47
Conversation
Oh yea that's right. That would be a great PR on the observe-sdk repo! |
I can add those onto the Go SDK today. I think I already have a branch for it. |
What should we do with this PR? been on my review list for a long time |
In our meeting last week we decided to let it sit until things progress with migration to The biggest change in-flux that would possibly impact this is the addition of a Context parameter to the instrumentation functions. cc/ @chrisdickinson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good, happy to see this land soon.
@G4Vi thanks for your feedback, I think the PR is ready to be merged |
Fixes #21