Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROW-556: Update go (v1.18 -> v1.21) #8

Merged
merged 1 commit into from
Feb 20, 2024
Merged

GROW-556: Update go (v1.18 -> v1.21) #8

merged 1 commit into from
Feb 20, 2024

Conversation

laverion
Copy link
Contributor

@laverion laverion commented Feb 15, 2024

Updating go version to 1.21. This PR also includes updating the version of go used to create the build artifacts in releases.

Tested the go version updates with the below command:

liamaverion@LAVERION-584 aws-resource-counter % go build .
liamaverion@LAVERION-584 aws-resource-counter % go test
PASS
ok      github.com/expel-io/aws-resource-counter        1.009s
liamaverion@LAVERION-584 aws-resource-counter % ./aws-resource-counter --profile resource-counter-test
Cloud Resource Counter (v?.?.?) running with:
 o AWS Profile: resource-counter-test
 o AWS Region:  (All regions supported by this account)
 o Output file: resources.csv

Activity
 * Retrieving Account ID...OK (211249992032)
 * Retrieving EC2 counts....................OK (7)
 * Retrieving Spot instance counts....................OK (0)
 * Retrieving EBS volume counts....................OK (25)
 * Retrieving Unique container counts....................OK (1)
 * Retrieving Lambda function counts....................OK (2)
 * Retrieving RDS instance counts....................OK (1)
 * Retrieving Lightsail instance counts.................OK (0)
 * Retrieving S3 bucket counts...OK (29)
 * Retrieving EKS Node counts....................OK (0)
 * Writing to file...OK

Success.

Verified the numbers returned for this specific account also matched with the numbers through the browser.

@laverion
Copy link
Contributor Author

Also happy to discuss these PR changes in the upcoming meeting Katharine scheduled for us.

@laverion laverion marked this pull request as ready for review February 15, 2024 20:54
@laverion laverion merged commit 7578a67 into main Feb 20, 2024
7 checks passed
@laverion laverion deleted the la.GROW-556 branch February 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants