Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROW-760: Update README about env variables #11

Merged
merged 3 commits into from
May 21, 2024
Merged

GROW-760: Update README about env variables #11

merged 3 commits into from
May 21, 2024

Conversation

laverion
Copy link
Contributor

@laverion laverion requested review from intertwine and Xxyumi-hub May 21, 2024 15:49
README.md Outdated
@@ -55,7 +55,8 @@ There are several ways to provide credentials.
### Environment variables
If you do not specify a profile when running the tool, or the profile you specify does not contain credentials, the
tool will use the following environment variables. This enables tools such as HashiCorp's Vault to work seamlessly
with the tool.
with the tool. <br/>
**These environment variables will not be utilized if you have a default profile configured. You must remove the default profile in order to utilize theses environment variables within this script.**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit the(?) instead of theses

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like "You must remove the default profile to use the following environment variables within this script:"

@laverion laverion merged commit ccdc18e into main May 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants