Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CTPG script options parser #967

Closed
tomuben opened this issue Oct 1, 2024 · 2 comments · Fixed by #968
Closed

Add CTPG script options parser #967

tomuben opened this issue Oct 1, 2024 · 2 comments · Fixed by #968
Assignees
@redcatbear @tomuben
Labels
refactoring Code improvement without behavior change

Comments

@tomuben
Copy link
Collaborator

tomuben commented Oct 1, 2024 •
edited
Loading

Background

Part of #652
This task is part of our effort to implement a more robust script options parser for the UDF client.

Acceptance Criteria

  1. Add Script Options parser based on CTPG library.
  2. The goal is to have a parser which can parse generic script options and return the found script option keys + values.
  3. Unit tests which validate correct behavior of the parser when applying to different UDF's with script options.

What is not scope of the task

  1. No modification of the original script code needed (as is done in the legacy parser).
  2. No integration of the new parser in Java VM of the udf client
@tomuben tomuben self-assigned this Oct 1, 2024
@tomuben tomuben added the refactoring Code improvement without behavior change label Oct 1, 2024
This was referenced Oct 1, 2024
Merged
Merged
Closed
@redcatbear redcatbear self-assigned this Oct 2, 2024
@redcatbear
Copy link
Contributor

Review: +3h

@Nicoretti
Copy link
Member

3h review time from @redcatbear

tomuben added a commit to exasol/script-languages that referenced this issue Oct 9, 2024
@tomuben
#967: Added ctpg script options parser (#454)
b37f762 
related to exasol/script-languages-release#967
tomuben added a commit that referenced this issue Oct 10, 2024
@tomuben
#967: Added ctpg script options parser (#968)
e79f74d 
fixes #967
@tomuben tomuben closed this as completed Oct 10, 2024
tomuben added a commit that referenced this issue Oct 15, 2024
@tomuben
Merge pull request #979 from exasol/develop
0d90dc1 
Changelist:

- * #944: Removed exaudfclient_bin_py3 (#975)
- * #967: Added ctpg script options parser (#968)
- * #972 and #973: Refactorings for Script Options parser (#976)
- * #977: Fixed Trivy update cache workflow (#978)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redcatbear redcatbear

@tomuben tomuben

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#967: Added ctpg script options parser exasol/script-languages-release
3 participants
@redcatbear @Nicoretti @tomuben