Runtime debug options [WIP] #170
Conversation
|
Sorry I wasn't clear (was just moving issues from the old testnet issue). I'd like to:
e.g. always compile support for debug, but don't run with debug. Also have the option to compile a much more optimised version (for benchmarking?) |
src/eei.h
Outdated
| @@ -115,6 +119,9 @@ struct EthereumInterface : ShellExternalInterface { | |||
| evm_message const& msg; | |||
| std::vector<uint8_t> lastReturnData; | |||
| ExecutionResult & result; | |||
| const bool debug; | |||
| /* FIXME */ | |||
| // static std::ostream& DebugStream; | |||
There was a problem hiding this comment.
@axic :
What I am doing here to replace HERA_DEBUG (previously defined by build options) is an ostream object reference that is defined for each instance of EthereumInterface, based on the debug flag. The issue I am having is that I want to use the NullStream struct we have defined already (the one without the large amount of useless inherited public methods), but this will not work because it is not an ostream like std::cerr. What is the best way to do this?
There was a problem hiding this comment.
Can you give an example what is not working?
There was a problem hiding this comment.
Nothing is broken at the moment, but I am not sure what is the best way to implement the HERA_DEBUG stream such that it works with runtime debug options.
What I do at the moment is give EthereumInterface an object reference to a stream, which is either NullStream or std::cerr depending on what value of "debug" is passed to the constructor. This doesn't work because NullStream is not an ostream and so DebugStream cannot refer to it.
The two solutions I have in mind are:
- Implement NullStream with std::ostream as the base class and inherit a bunch of stuff we don't need
- preprocessor hell
This is not super important because I am redoing this later, retaining compile-time options, but I would like to know how to approach this type of issue.
|
@axic oh, ok. I would still however like to hear the answer to the question I asked above about the debugstream ^^^ |
|
Why did you close it? :) |
|
I am redoing this on a different branch, where i keep the compile-time options and don't do stupid things like pass the debug bool to each function that needs it. |
|
You can force push into this branch. Just make sure to reopen it before force pushing, otherwise it wont let it to be reopened. |
|
@axic I think it makes sense to build this on top of the VM abstraction layer. |
|
This will be implemented on top of the VM abstraction layer, when it is ready. |
fixes #169