-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable expansion missing global reference #83
Comments
evmar
added a commit
that referenced
this issue
Aug 30, 2023
Colecf
added a commit
to Colecf/n2
that referenced
this issue
Dec 29, 2023
This fixes an incompatibility with ninja. I've also refactored Env to make it clearer and remove the TODO(evmar#83), but I actually think we could do signifigant further cleanup. Only rules should require EvalStrings, global variables and build bindings can be evaluated as soon as they're read, although maybe that would change with subninjas. Also, rules currently parse their variables as EvalString<String>, but I think that could be changed to EvalString<&'text str> if we hold onto the byte buffers of all the included files until the parsing is done. Fixes evmar#91, and evmar#39.
Colecf
added a commit
to Colecf/n2
that referenced
this issue
Dec 29, 2023
This fixes an incompatibility with ninja. I've also refactored Env to make it clearer and remove the TODO(evmar#83), but I actually think we could do signifigant further cleanup. Only rules should require EvalStrings, global variables and build bindings can be evaluated as soon as they're read, although maybe that would change with subninjas. Also, rules currently parse their variables as EvalString<String>, but I think that could be changed to EvalString<&'text str> if we hold onto the byte buffers of all the included files until the parsing is done. Fixes evmar#91 and evmar#39.
Colecf
added a commit
to Colecf/n2
that referenced
this issue
Dec 29, 2023
This fixes an incompatibility with ninja. I've also refactored Env to make it clearer and remove the TODO(evmar#83), but I actually think we could do signifigant further cleanup. Only rules should require EvalStrings, global variables and build bindings can be evaluated as soon as they're read, although maybe that would change with subninjas. Also, rules currently parse their variables as EvalString<String>, but I think that could be changed to EvalString<&'text str> if we hold onto the byte buffers of all the included files until the parsing is done. Fixes evmar#91 and evmar#39.
Colecf
added a commit
to Colecf/n2
that referenced
this issue
Dec 29, 2023
This fixes an incompatibility with ninja. I've also refactored Env to make it clearer and remove the TODO(evmar#83), but I actually think we could do signifigant further cleanup. Only rules should require EvalStrings, global variables and build bindings can be evaluated as soon as they're read, although maybe that would change with subninjas. Also, rules currently parse their variables as EvalString<String>, but I think that could be changed to EvalString<&'text str> if we hold onto the byte buffers of all the included files until the parsing is done. Fixes evmar#91 and evmar#39.
Colecf
added a commit
to Colecf/n2
that referenced
this issue
Dec 29, 2023
This fixes an incompatibility with ninja. I've also refactored Env to make it clearer and remove the TODO(evmar#83), but I actually think we could do signifigant further cleanup. Only rules should require EvalStrings, global variables and build bindings can be evaluated as soon as they're read, although maybe that would change with subninjas. Also, rules currently parse their variables as EvalString<String>, but I think that could be changed to EvalString<&'text str> if we hold onto the byte buffers of all the included files until the parsing is done. Fixes evmar#91 and evmar#39.
Colecf
added a commit
to Colecf/n2
that referenced
this issue
Dec 29, 2023
This fixes an incompatibility with ninja. I've also refactored Env to make it clearer and remove the TODO(evmar#83), but I actually think we could do signifigant further cleanup. Only rules should require EvalStrings, global variables and build bindings can be evaluated as soon as they're read, although maybe that would change with subninjas. Also, rules currently parse their variables as EvalString<String>, but I think that could be changed to EvalString<&'text str> if we hold onto the byte buffers of all the included files until the parsing is done. Fixes evmar#91 and evmar#39.
Colecf
added a commit
to Colecf/n2
that referenced
this issue
Dec 31, 2023
This fixes an incompatibility with ninja. I've also refactored Env to make it clearer and remove the TODO(evmar#83), but I actually think we could do signifigant further cleanup. Only rules should require EvalStrings, global variables and build bindings can be evaluated as soon as they're read, although maybe that would change with subninjas. Also, rules currently parse their variables as EvalString<String>, but I think that could be changed to EvalString<&'text str> if we hold onto the byte buffers of all the included files until the parsing is done. Fixes evmar#91 and evmar#39.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#39 (comment)
Distilled it to:
This runs
echo hello 123
when it should runecho 123 hello 123
The text was updated successfully, but these errors were encountered: