Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven? #97

Open
fsiler opened this issue Jan 12, 2017 · 2 comments
Open

Maven? #97

fsiler opened this issue Jan 12, 2017 · 2 comments

Comments

@fsiler
Copy link

fsiler commented Jan 12, 2017

Would this project be inclined to accept PRs related to Mavenization? I'm just getting started with Java build tools and want to play with jstylo, so this seems like a worthy start. Thanks for any advice.
@mvryan
Copy link
Member

mvryan commented Jan 12, 2017

Hi, Frank. Thank you for the interest and offer of help.

I do want to let you know that Mavenising JGAAP would not help jStylo. They depend on the version 5 line of JGAAP and have modified it internally. JGAAP's internal API has changed significantly in since that time to allow the use of multiple EventDrivers each with their own Canonicizers and Cullers. I'm not sure if the psal at Drexel has ever published the modified source of JGAAP but that is what you would want to get up on Maven to simply the build process.

If you are still interested in helping us by updating JGAAP to use Maven, we would be happy to review any pull request.

Just to let you know the biggest thing holding back a proper 7.0 release of JGAAP is UI work if you're interested in that.

Best,
Mike

@fsiler
Copy link
Author

fsiler commented Jan 13, 2017

Sure, jstylo needs some work in other areas- for one, using reflection would be nice :). Let me dig in a bit and see where the pain comes up, and hopefully I can send a couple useful patches your way. Many thanks.

Frank

games647 added a commit to games647/JGAAP that referenced this issue Sep 3, 2017
@games647
Mavenize project (Related to evllabs#97)
8c392af 
* Removed IDE dependent files (classpath, .project)
* Update gitignore to ignore IDE related files and the Maven output folder
* Removed dependencies if they are available as Maven artifacts
* Changed resources path according to the Maven standard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvryan @fsiler