Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON should not be constructed manually. #14

Open
4 tasks
lewisgoddard opened this issue Oct 22, 2016 · 1 comment
Open
4 tasks

JSON should not be constructed manually. #14

lewisgoddard opened this issue Oct 22, 2016 · 1 comment
Labels
Language: PHP ⚠️ Priority: Medium 🍀 Size: Bytesize ✨ Type: Enhancement 👍 Status: Confirmed
Milestone
Code

Comments

@lewisgoddard
Copy link
Member

lewisgoddard commented Oct 22, 2016 •
edited
Loading

Expected behavior

_templates/schema.php should construct JSON from an array using the PHP function.

Actual behavior

JSON is manually constructed via string concentration.

  • Website Logo Schema
  • Website Name Schema
  • Website Social Schema
  • Article Schema

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Language: PHP ⚠️ Priority: Medium 🍀 Size: Bytesize ✨ Type: Enhancement 👍 Status: Confirmed
Projects
None yet
Milestone
Code
Development

No branches or pull requests
1 participant
@lewisgoddard