Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support workspace inheritance #74

Closed
taqtiqa-mark opened this issue Mar 28, 2022 · 3 comments · Fixed by #104
Closed

Support workspace inheritance #74

taqtiqa-mark opened this issue Mar 28, 2022 · 3 comments · Fixed by #104

Comments

@taqtiqa-mark
Copy link

taqtiqa-mark commented Mar 28, 2022

I've encountered this issue while implementing a infinyon/fluvio plugin-style integration test harness for Minitest, PR tikv/minitrace-rust/pull/127.

I have now reproduced the issue in a test-virtual project that will, hopefully, land here via PR #72.

The test-virtual example shows how to setup macrotest with a generic (non-libtest) test harness, and allows macrotest users to compare this plugin-style integration test suite with the default Rust libtest test harness.

At the moment the test-virtual project returns this error:

cargo test integration-tests 

<snip>

Expansion error:
error: Package `wrkspc-test-tests v0.0.0 (/home/user/src/macrotest/test-virtual/target/tests/wrkspc-test/macrotest000)` does not have the feature `test-feature`

I've banged my head on both projects but can't seem to figure out where the mismatch is occuring.

Appreciate any help or insights you can share.

taqtiqa-mark added a commit to taqtiqa-mark/macrotest that referenced this issue Mar 28, 2022
Signed-off-by: Mark Van de Vyver <[email protected]>
@taqtiqa-mark taqtiqa-mark changed the title Plugin-style integration test suites - feature flags: Package macrotest000 does not have the feature test-feature Package macrotest000 does not have the feature test-feature Mar 28, 2022
@taqtiqa-mark
Copy link
Author

Note to self to investigate possible workaround:

Cargo virtual manifests do not support the [features] stanza (without also
having the [package] stanza). See Cargo issue 4942.

taqtiqa-mark added a commit to taqtiqa-mark/macrotest that referenced this issue Mar 10, 2024
Signed-off-by: Mark Van de Vyver <[email protected]>
@taiki-e
Copy link
Collaborator

taiki-e commented Mar 30, 2024

This is because workspace inheritance is not yet supported. EDIT: #74 (comment)

@taiki-e taiki-e changed the title Package macrotest000 does not have the feature test-feature Support workspace inheritance Mar 30, 2024
@taiki-e
Copy link
Collaborator

taiki-e commented Mar 30, 2024

error: Package `wrkspc-test-tests v0.0.0 (/home/user/src/macrotest/test-virtual/target/tests/wrkspc-test/macrotest000)` does not have the feature `test-feature`

Ah, nah, the direct reason for this error itself could be due to a failure to parse the edition (fixed by #92).

However, as far as I can see #72, even if that error is fixed, it is likely that another error will be shown because of the workspace inheritance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants