Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yelpSearch #1

Open
euleong opened this issue Mar 25, 2014 · 3 comments
Open

yelpSearch #1

euleong opened this issue Mar 25, 2014 · 3 comments

Comments

@euleong
Copy link
Owner

euleong commented Mar 25, 2014

/cc @nesquena @timothy1ee

@timothy1ee
Copy link

Hmm, why is there no workspace or Pods file?

@euleong
Copy link
Owner Author

euleong commented Mar 26, 2014

Just pushed them.

@timothy1ee
Copy link

Awesome work! I think you get what's required to make a polished app. Try to challenge yourself to implement polish features that you see in the app store. Not necessarily flashy things, but it's the small details that take a lot of work.

  • Be sure to check if a delegate responds to a selector before calling an optional protocol method on it.
  • In your cellForRow method, move everything you can to either the model layer or to the custom cell for better encapsulation.

The purpose of this assignment was to explore the following:

  • Table views with dynamic height rows and custom cells with Auto Layout.
  • Table views that contain controls for user input and binding those controls to form data.
  • Advanced features of table views such as row animation and section views.
  • Linking two view controllers view a custom delegate pattern.

Here's my checklist as I'm reviewing the submissions:

  • Code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
  • Custom cells.
    • Are the subviews of the cell exposed in the public header or are they properly encapsulated?
    • Do the nibs have the proper Auto Layout constraints?
    • Are the cells registered with the table view?
  • Filter view controller
    • Are the controls properly bound with the form data?
    • Is there a custom delegate to notify the search view controller of new filter settings?
    • Is there a section in the table view that accordians out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants