Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Test coverage for -DCASE_INSENSITIVE is lacking. #310

Open
1 task done
bcsgh opened this issue Apr 6, 2023 · 0 comments
Open
1 task done

[BUG] Test coverage for -DCASE_INSENSITIVE is lacking. #310

bcsgh opened this issue Apr 6, 2023 · 0 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@bcsgh
Copy link
Contributor

bcsgh commented Apr 6, 2023

Prerequisites

Description

Some digging around for other reason shows that http_endpoint::operator< is unconditionally case-insensitive. This strongly implies that there are gaps in the test suite relating to builds with -DCASE_INSENSITIVE.

Steps to Reproduce

Play around with this: 518a966

Expected behavior: Test coverage both with and withou -DCASE_INSENSITIVE and the cases where they differ.

Actual behavior: A test I added for one case surfaced a bug.

Versions

Current master.

@bcsgh bcsgh added the bug Confirmed bugs or reports that are very likely to be bugs. label Apr 6, 2023
@bcsgh bcsgh assigned etr Apr 6, 2023
bcsgh added a commit to bcsgh/libhttpserver that referenced this issue Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

2 participants