ESLint + Editorconfig #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toastal
commented
May 29, 2020
| @@ -106,9 +101,9 @@ function formatIdeResult(result, options, index, length) { | |||
| // strip newlines at the end | |||
| if (endsOnNewline) { | |||
| trimmed = lines.reverse().reduce((trimmed, line, i) => { | |||
There was a problem hiding this comment.
Unrelated question: wouldn't this be better as lines.reduceRight over lines.reverse().reduce? (with i === lines.length - 1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my personal proposal for ESLint and Editorconfig with the aesthetic goal of blending established JavaScript standards with ergonomics slightly closer to PureScript:
With ESLint the base is
eslint-config-standardwhich is quite common. With notable deviations:Things the maintainer may want to adjust:
semi: always): it seems semicolons were used more often than not, but it wasn't consistent andeslint-config-standarduses"never"quotesblock): single quotes seemed to be used more often, and while the JS community seems to have a favoritism towards singles, PureScript/Haskell/etc. use singles just for chars only which may not be the muscle memory for PureScript developers + strings 🤷.Other changes caught by the linter:
"useless"escaped\.in theRegExps according to ESLint!= ""for an empty string.To rerun+fix the linting if you were to make adjustments:
fixes #147