Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement testing plans #140

Open
mhchia opened this issue Dec 25, 2018 · 3 comments
Open

Implement testing plans #140

mhchia opened this issue Dec 25, 2018 · 3 comments
Assignees

Comments

@mhchia
Copy link
Collaborator

mhchia commented Dec 25, 2018

What is wrong?

Per the request from the whiteblock team, we had a script to run docker containers for testing. Only two test cases are finished previously, and we should keep finishing the remaning test plans specified in https://notes.ethereum.org/Q_kQKXZUQD29YCshej1qPQ . IMO we can finish the python script and test in the local environment first, and integrate it into our ansible modules when we need to test with clouds.

How can it be fixed?

  • Implement all test plans specified in the note.
  • Have a more readable and reusable structure
@mhchia mhchia self-assigned this Dec 25, 2018
@mhchia
Copy link
Collaborator Author

mhchia commented Dec 25, 2018

@mhchia
Copy link
Collaborator Author

mhchia commented Dec 31, 2018

[Note] Thought on measurement/metrics: we can probably measure through hopcount, instead of only the time. The advantage of this metric is we can focus more on the network topology and the dissemination of messages, instead of the real world environments.

One problem is we don't have the field hopcount in the current broadcasted Message. An easy solution is we can add it inside data.

@zscole
Copy link
Contributor

zscole commented Dec 31, 2018

Sorry for the late response! We will be back in the office on Wednesday and will continue the tests then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants