Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expireLimited with max uint256 failing #237

Open
n00b21337 opened this issue Dec 20, 2023 · 0 comments
Open

expireLimited with max uint256 failing #237

n00b21337 opened this issue Dec 20, 2023 · 0 comments
Labels

Comments

@n00b21337
Copy link
Contributor

n00b21337 commented Dec 20, 2023

Problem

The pattern where we have in PostageStamp

expireLimited(type(uint256).max);

will fail in FOR loop when there is too big a number of potential expires, so far this hasnt been happening as usually there is not that much expiring and there is BREAK in loop, but once number of batches get bigger this will happen and then this expiries will get a bit stuck and transactions for them will fail as there will be hit of gas limits of block in chain.

Solution

We need to get to some reasonable max limit that will be max no matter what

@bee-runner bee-runner bot added the issue label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant