fix: rename swarm key #4647
Open
fix: rename swarm key #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The key previously known as swarm.key is now named wallet.key. This change is necessary to improve the clarity of the key's purpose.
|
Why? Since the swarm.key is also used to generate the swarm overlay? It's not just a "wallet" key IMHO. |
|
Frankly, I am not qualified/experienced enough in bee to give a proper reason for the change. I am just looking around to contribute to this project and I found #4023 in the good first issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
In a new node
wallet.keywill be created instead ofswarm.key. In an old node theswarm.keywill be renamed towallet.keyon start. Due to this, downgrading the node won't be possible because of the name change.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
fixes #4023
Screenshots (if appropriate):