feat: cleanup and repair commands #4587
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notanatol
commented
Feb 21, 2024
pkg/storer/fix_refcnt.go
Outdated
| refs := make(map[uint32]uint32) | ||
| for _, item := range items { | ||
| refs[item.item.RefCnt]++ | ||
| newRefCnt := item.pinCnt*100 + item.reserveCnt + item.cacheCnt + item.uploadCnt |
There was a problem hiding this comment.
@ldeffenb what is the reason for this multiplication? item.pinCnt*100
There was a problem hiding this comment.
That is one of my hacks that you don't need. In my case, if a chunk is pinned, I want it to STAY in the sharky regardless of the bugs that might inappropriately decrement the refCnt by 1 here or there. You'll just want pinCnt, and drop the *100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Porting two of @ldeffenb functionalities for fixing incorrect reference count and removing invalid chunks from sharky.
Closes: #4566