Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out a type from access lists #947

Open
SamWilsn opened this issue May 10, 2024 · 5 comments · May be fixed by #960
Open

Factor out a type from access lists #947

SamWilsn opened this issue May 10, 2024 · 5 comments · May be fixed by #960
Labels
A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers
Milestone
Post-Prague Re-fa...

Comments

@SamWilsn
Copy link
Collaborator

For example:

execution-specs/src/ethereum/cancun/transactions.py

Line 62 in 0f116b5

access_list: Tuple[Tuple[Address, Tuple[Bytes32, ...]], ...]

Because it's repeated in several different transaction types, the Tuple[Address, Tuple[Bytes32, ...]] portion should be promoted to its own type. Something like:

@slotted_freezable
@dataclass
class Access:
    account: Address
    slots: Tuple[Bytes32, ...]
@SamWilsn SamWilsn added A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers labels May 10, 2024
@SamWilsn SamWilsn added this to the Post-Cancun Refactoring milestone May 10, 2024
@richardgreg
Copy link
Contributor

And this, too?

@SamWilsn
Copy link
Collaborator Author

Help is always appreciated, but this one might be a bit harder than I originally estimated because of the RLP encoding. Feel free to take a stab at it (and make a separate PR for Prague) if you want!

@Redidacove
Copy link
Contributor

@SamWilsn I am curious to know how can I contribute to a specific fork
Like forks/prague when I fork the repo and clone it to my VS Code and start coding how can I get code of a specific branch I know it maybe a beginner question but can you please clear my doubt.

@SamWilsn
Copy link
Collaborator Author

Most of the forks are just in the master branch (eg. src/ethereum/constantinople), but the "next" fork is in forks/prague.

@richardgreg richardgreg linked a pull request Jun 6, 2024 that will close this issue
Open
@richardgreg
Copy link
Contributor

I've opened a draft PR at #960. @SamWilsn, if it looks good, I can implement it for each branch's transactions.py.

@Redidacove if you're interested, then you can implement the same changes and open a PR against Prague

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers
Projects
None yet
Milestone
Post-Prague Re-factoring
Development

Successfully merging a pull request may close this issue.

enhancement: factor out a type from access lists richardgreg/execution-specs
4 participants
@richardgreg @gurukamath @SamWilsn @Redidacove