Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create story for Contributors component #13878

Open
4 tasks
Tracked by #13043
corwintines opened this issue Sep 17, 2024 · 3 comments · May be fixed by #13978
Open
4 tasks
Tracked by #13043

Create story for Contributors component #13878

corwintines opened this issue Sep 17, 2024 · 3 comments · May be fixed by #13978
Assignees
@Baystef
Labels
dev required This requires developer resources Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@corwintines
Copy link
Member

corwintines commented Sep 17, 2024 •
edited
Loading

Create story tests for Contributors component

Prerequisite

To get yourself up to speed on how we use storybook on ethereum.org, learn more here

What to do

  • Move /src/components/Contributors.tsx to /src/components/Contributors/index.tsx
  • Fix any filepath changes to imports for the Contributors component
  • Create story file /src/components/Contributors/Contributors.stories.tsx
  • Writes story testing render of Contributors component in context of use

Context

Used on contributors page which renders in the MainArticle component in the Static template
@corwintines corwintines mentioned this issue Sep 17, 2024
Open
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Sep 17, 2024
@corwintines corwintines changed the title Contributors Create story for Contributors component Sep 17, 2024
@corwintines
Copy link
Member Author

@Baystef could you comment here so I can assign you :)

@Baystef
Copy link
Contributor

Baystef commented Sep 17, 2024

@corwintines please assign to me

@corwintines corwintines added dev required This requires developer resources and removed needs triage 📥 This issue needs triaged before being worked on labels Sep 17, 2024
Baystef added a commit to Baystef/ethereum-org-website that referenced this issue Sep 26, 2024
@Baystef
feat(contributors story): create story for contributors component [et…
2d10e0f 
…hereum#13878]
@Baystef Baystef linked a pull request Sep 26, 2024 that will close this issue
Open
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Baystef Baystef

Labels
dev required This requires developer resources Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create Story for Contributors Component Baystef/ethereum-org-website
2 participants
@corwintines @Baystef