Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

don't return null when dag file mismatch #58

Closed
subtly opened this issue May 17, 2015 · 1 comment
Closed

don't return null when dag file mismatch #58

subtly opened this issue May 17, 2015 · 1 comment

Comments

@subtly
Copy link
Member

subtly commented May 17, 2015

The code below should either re-run the creation with force, delete the file and rerun, or inform the user to delete the file. Otherwise there is no way to determine what was wrong -- and a dag created by previous version of the software will fail.

if (file_size != found_size - ETHASH_DAG_MAGIC_NUM_SIZE) {
                fclose(f);
                ret = ETHASH_IO_MEMO_SIZE_MISMATCH;
                goto free_memo;
            }
@subtly
Copy link
Member Author

subtly commented May 17, 2015

Ah, I see that logic outside.

@subtly subtly closed this as completed May 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant