Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2021-08-21 reports wrong version #68

Open
lilyball opened this issue Jan 13, 2022 · 2 comments
Open

Release 2021-08-21 reports wrong version #68

lilyball opened this issue Jan 13, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@lilyball
Copy link

Release 2021-08-21 still reports version "2021.04.06", as the version.txt file was never updated.

@grawlinson
Copy link

I'm probably pushing a fix downstream (Arch Linux) with this particular command:

 git show --no-patch --format=%cd --date=format:%Y.%m.%d > version.txt

Doesn't really work when there are multiple commits in a single day, but the package version appends number of commits from last release & the commit hash anyway. ($VERSION.r$NO_COMMITS.$COMMIT_HASH)

@eth-p
Copy link
Owner

eth-p commented Jul 29, 2022

Whoops. I've released a new version since then. Is this still a problem @lilyball, or does the new version having the correct version fix that?

Either way, I'll be keeping this open as a reminder to improve/automate the release process to avoid this kind of human error in the future.

@eth-p eth-p added the bug Something isn't working label Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants