Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add component upload GH action (AIV-648) #136

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

tore-espressif
Copy link
Contributor

Hello @Auroragan
Here is simple PR that adds GH action that uploads esp-dl component to IDF Component Registry.
Few points:

  • You will have to add a GH secret named IDF_COMPONENT_API_TOKEN to you GH project (here's a docu link ICYMI). @kumekay) can generate one for you
  • The GH action will run on every time a tag is pushed (eg 1.0.1 or v1.0.1), so it expects that you tag your releases. (there is also an option to bump the version manually in idf_component.yml , but this is recommended for repositories that contain more than 1 component)
  • I can see that in your idf_component.yml you support only esp-idf 5.0.x . Are you sure this cannot be extended to 5.* ? Are there any blockers to support IDF 5.1 and 5.2?

Closes #135

@github-actions github-actions bot changed the title ci: Add component upload GH action ci: Add component upload GH action (AIV-648) Sep 7, 2023
@Auroragan
Copy link

Hi @tore-espressif, thanks for the help.

For the first step, I guess I'm not able to change the setting of this repo. Do you have any idea who could help with this?

And the reason why it's esp-idf 5.0.x in the yml file is that these .a files in the repo (eg. https://github.com/espressif/esp-dl/blob/master/lib/esp32s3/libdl.a) are compiled under this version. If they are compatible with 5.* then I guess it can be extended.

@tore-espressif
Copy link
Contributor Author

@igrr would you know who is the maintainer of this repo? We want to add IDF Component Manager secret, for upload jobs

@igrr
Copy link
Member

igrr commented Sep 15, 2023

IDF_COMPONENT_API_TOKEN has been added!

@Auroragan Auroragan merged commit b0f3866 into espressif:master Sep 15, 2023
@tore-espressif
Copy link
Contributor Author

@Auroragan I will manually upload already released versions 1.1 and 2.0, OK?

@tore-espressif tore-espressif deleted the feat/upload-component branch September 15, 2023 12:34
@Auroragan
Copy link

Sure. Thanks!

@tore-espressif
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload esp-dl to IDF Component Registry (AIV-647)
3 participants