Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for CH422G I/O Expander #4210

Merged
merged 12 commits into from
Sep 2, 2024
Merged

Conversation

jesterret
Copy link
Contributor

Description:

Documentation for the component

Related issue (if applicable):

Pull request in esphome with YAML changes (if applicable): esphome/esphome#7356

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

@jesterret
Copy link
Contributor Author

If possible, could I request someone to create the SVG for it? 😄

@clydebarrow
Copy link
Contributor

@esphomebot generate image CH422G

Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit f6f5b89
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/66d51a8aab2a3d0008091a80
😎 Deploy Preview https://deploy-preview-4210--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jesserockz
Copy link
Member

@esphomebot generate image CH422G

Copy link

github-actions bot commented Sep 1, 2024

@jesserockz Here is the image for the component

@jesserockz
Copy link
Member

Here is the generated file. I need to look into the workflow to see why its not working

<svg viewBox="0 0 120 25" id="svg5" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg"><defs id="defs9"/><path d="M5 0H115a5 5 0 015 5v15a5 5 0 01-5 5H5a5 5 0 01-5-5V5a5 5 0 015-5z" style="fill:#000" id="path2"/><g aria-label="CH422G" id="component-text" style="font-weight:900;font-size:25px;font-family:Montserrat;letter-spacing:1.1px;fill:#fffffc"><path d="m15.475 21.4q-2.1.0-3.9-.65-1.775-.675-3.1-1.9-1.3-1.225-2.025-2.9-.725-1.675-.725-3.7t.725-3.7q.725-1.675 2.025-2.9 1.325-1.225 3.1-1.875 1.8-.675 3.9-.675 2.575.0 4.55.9 2 .9 3.3 2.6L19.6 9.925q-.775-.975-1.725-1.5-.925-.55-2.1-.55-.925.0-1.675.3t-1.3.875q-.525.575-.825 1.4-.3.8-.3 1.8t.3 1.825q.3.8.825 1.375.55.575 1.3.875t1.675.3q1.175.0 2.1-.525.95-.55 1.725-1.525l3.725 3.325q-1.3 1.675-3.3 2.6-1.975.9-4.55.9z" id="path11"/><path d="m37.474987 3.5h5.9V21h-5.9zm-5.45 17.5h-5.9V3.5h5.9zm5.85-6.45h-6.25V9.7h6.25z" id="path13"/><path d="m46.475009 18v-3.75l7.425-10.75h6.05l-7.15 10.75-2.75-.825h13.55V18zm9.075 3v-3l.175-4.575V10.75h5.55V21z" id="path15"/><path d="m65.500007 21v-3.625l6.325-5.85q.6-.575.875-1 .3-.425.4-.75.1-.35.1-.65.0-.65-.425-1-.425-.375-1.275-.375-.775.0-1.475.425-.7.4-1.1 1.2l-4.45-2.225q.95-1.8 2.85-2.925 1.9-1.125 4.725-1.125 2.075.0 3.675.675t2.5 1.9q.9 1.225.9 2.9.0.85-.225 1.7-.2.85-.85 1.8-.65.925-1.925 2.075l-4.75 4.325-.925-2.05h9.075V21z" id="path17"/><path d="m81.799998 21v-3.625l6.325-5.85q.6-.575.875-1 .3-.425.4-.75.1-.35.1-.65.0-.65-.425-1-.425-.375-1.275-.375-.775.0-1.475.425-.7.4-1.1 1.2l-4.45-2.225q.95-1.8 2.85-2.925 1.9-1.125 4.725-1.125 2.075.0 3.675.675t2.5 1.9q.9 1.225.9 2.9.0.85-.225 1.7-.2.85-.85 1.8-.65.925-1.925 2.075l-4.75 4.325-.925-2.05h9.075V21z" id="path19"/><path d="m107.89999 21.4q-2.125.0-3.925-.65-1.775-.675-3.1-1.9-1.299996-1.225-2.024996-2.9-.725-1.675-.725-3.7t.725-3.7q.725-1.675 2.049996-2.9 1.325-1.225 3.125-1.875 1.825-.675 4-.675 2.6.0 4.625.875 2.05.875 3.375 2.5l-3.775 3.325q-.825-.95-1.8-1.425-.95-.5-2.125-.5-.975.0-1.775.3-.775.3-1.325.875t-.85 1.375-.3 1.825q0 .975.3 1.8.3.8.85 1.375t1.3.9q.775.3 1.725.3 1 0 1.95-.325.95-.35 2.025-1.175l3.3 4.05q-1.6 1.075-3.65 1.65-2.05.575-3.975.575zm2.5-2.975v-6.65h5.125v7.4z" id="path21"/></g></svg>

Copy link

github-actions bot commented Sep 1, 2024

@jesserockz Here is the image for the component

@jesserockz
Copy link
Member

@esphomebot generate image ch422g

Copy link

github-actions bot commented Sep 1, 2024

@clydebarrow
Copy link
Contributor

I liked the upper case version better :-(

@clydebarrow
Copy link
Contributor

@esphomebot generate image CH422G

Copy link

github-actions bot commented Sep 1, 2024

@clydebarrow Here is the image for the component

@jesterret
Copy link
Contributor Author

I liked the upper case version better :-(

For what it's worth, me too :)
Ran the container locally to get it in the meantime

@jesserockz
Copy link
Member

The image itself is supposed to be uppercase =)
Just the filename is lowercase
I must have messed up somewhere else

@jesserockz
Copy link
Member

#4214 will take the case of the name as is for the image, and fixes to always use the lowercase for filename.

components/ch422g.rst Outdated Show resolved Hide resolved
clydebarrow
clydebarrow previously approved these changes Sep 2, 2024
components/ch422g.rst Outdated Show resolved Hide resolved
components/ch422g.rst Outdated Show resolved Hide resolved
@clydebarrow clydebarrow merged commit 397a225 into esphome:next Sep 2, 2024
2 checks passed
@jesterret jesterret deleted the ch422g branch September 2, 2024 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants