Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader-compilation error-messages do not provide enough information #87

Open
JayFoxRox opened this issue May 14, 2017 · 0 comments
Open

Comments

@JayFoxRox
Copy link
Collaborator

JayFoxRox commented May 14, 2017

If XQEMU fails to compile / link a shader it currently only reports the compilation / link log (which is implementation dependent; Usually the line which caused the issue and a short message, but nothing else).
I think we should also include the complete set of shaders so it can be investigated more easily. This is also important because some drivers are very bad at generating a meaningful compilation / link log.
This will especially be helpful once we have users who will report bugs.
(A similar change was also done in Citra a while ago and it turned out to be useful)

The necessary changes should be done in hw/xbox/nv2a_shaders.c

Additionally we should probably dump the ShaderState to a file. That way we could more easily try to reproduce the error and also test proposed fixes without re-running the games. Such a tool could also be used in automated testing.
(We'll want a ShaderState dumper anyway so that we can generate commonly used shaders [from a database] at startup instead of runtime where it might cause microstutter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant