Use $LDFLAGS as default for $ESMF_*LINKOPTS

[xylar]

On conda-forge, we recently ran into an issue when upgrading to OpenMPI 5 that ESMF tests were failing with a linking error:

mpif90   -m64 -mcmodel=small -pthread -Wl,--no-as-needed -fopenmp -L$SRC_DIR/lib/libO/Linux.gfortran.64.openmpi.default -L$PREFIX/lib -L$PREFIX/lib -L$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/12.3.0/ -Wl,-rpath,$SRC_DIR/lib/libO/Linux.gfortran.64.openmpi.default -Wl,-rpath,$PREFIX/lib  -Wl,-rpath,$PREFIX/lib -Wl,-rpath,$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/12.3.0/ -o $SRC_DIR/test/testO/Linux.gfortran.64.openmpi.default/ESMF_StringUTest ESMCI_StringSubr.o  ESMF_StringUTest.o -lesmf  -lrt -lstdc++ -ldl -lnetcdff -lnetcdf -lpioc
/home/conda/feedstock_root/build_artifacts/esmf_1717757906123/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/12.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/esmf_1717757906123/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/./libpmix.so.2: undefined reference to `clock_gettime@GLIBC_2.17'
/home/conda/feedstock_root/build_artifacts/esmf_1717757906123/_build_env/bin/../lib/gcc/x86_64-conda-linux-gnu/12.3.0/../../../../x86_64-conda-linux-gnu/bin/ld: /home/conda/feedstock_root/build_artifacts/esmf_1717757906123/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/libmpi_mpifh.so: undefined reference to `memcpy@GLIBC_2.14'
collect2: error: ld returned 1 exit status

After some lengthy discussion, it was discovered that the issue was that $LDFLAGS was not being passed along to the linker by default, and setting:

export ESMF_CLINKOPTS="$LDFLAGS"
export ESMF_F90LINKOPTS="$LDFLAGS"
export ESMF_CXXLINKOPTS="$LDFLAGS"

fixed the issue. The feeling from a conda-forge maintainer (see https://github.com/conda-forge/esmf-feedstock/pull/117/files#r1634670892) was that this should probably be the default value within ESMF, so I'm proposing this change.

[danrosen25]

@theurich @oehmke
Does this seem system specific as it has to do with the GNU C library not being linked by the linker?
Or are we missing something in the build recipe for the ESMF_StringUTest executable?

mpif90
-m64
-mcmodel=small
-pthread
-Wl,--no-as-needed
-fopenmp
-L$SRC_DIR/lib/libO/Linux.gfortran.64.openmpi.default
-L$PREFIX/lib
-L$PREFIX/lib
-L$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/12.3.0/
-Wl,-rpath,$SRC_DIR/lib/libO/Linux.gfortran.64.openmpi.default
-Wl,-rpath,$PREFIX/lib
-Wl,-rpath,$PREFIX/lib
-Wl,-rpath,$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/12.3.0/
-o $SRC_DIR/test/testO/Linux.gfortran.64.openmpi.default/ESMF_StringUTest
ESMCI_StringSubr.o
ESMF_StringUTest.o
-lesmf
-lrt
-lstdc++
-ldl
-lnetcdff
-lnetcdf
-lpioc

[oehmke]

I think that this is probably a question for @theurich <https://github.com/theurich>, if it’s ok to wait until he has a chance to answer.

…

On Jun 13, 2024, at 3:05 PM, Daniel Rosen ***@***.***> wrote: @theurich <https://github.com/theurich> @oehmke <https://github.com/oehmke> Does this seem system specific as it has to do with the GNU C library not being linked by the linker? Or are we missing something in the build recipe for the ESMF_StringUTest executable? mpif90 -m64 -mcmodel=small -pthread -Wl,--no-as-needed -fopenmp -L$SRC_DIR/lib/libO/Linux.gfortran.64.openmpi.default -L$PREFIX/lib -L$PREFIX/lib -L$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/12.3.0/ -Wl,-rpath,$SRC_DIR/lib/libO/Linux.gfortran.64.openmpi.default -Wl,-rpath,$PREFIX/lib -Wl,-rpath,$PREFIX/lib -Wl,-rpath,$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda-linux-gnu/12.3.0/ -o $SRC_DIR/test/testO/Linux.gfortran.64.openmpi.default/ESMF_StringUTest ESMCI_StringSubr.o ESMF_StringUTest.o -lesmf -lrt -lstdc++ -ldl -lnetcdff -lnetcdf -lpioc — Reply to this email directly, view it on GitHub <#255 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE6A7U2MFB3WKF4CFOHCILLZHICSPAVCNFSM6AAAAABJFWZZKWVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TONRXG44DS>. You are receiving this because you were mentioned.

[danrosen25]

@theurich
Is this something we'd like to add to the backlog? As of now we don't pick up standard compiler/linker configuration options that are commonly picked up from the environment by other build systems.

• CC
• CFLAGS
• CXX
• CXXFLAGS
• FC
• FFLAGS
• LDFLAGS