no-undef error on ES6 import #1978

ai · 2015-03-08T20:52:37Z

As I understand ESLint doesn’t understand that import create variable.

So I get a 'Warning' is not defined error on line 2 of this code:

import Warning from '../lib/warning';
var warn = new Warning('text');

I uses eslint 0.16.1 and my .eslintrc is:

{
    "ecmaFeatures": {
        "modules": true,
        "module":  true
    },
    "env": {
        "mocha": true,
        "node":  true,
        "es6":   true
    }
}

/cc @nzakas

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The text was updated successfully, but these errors were encountered:

AsaAyers · 2015-03-09T00:14:21Z

I'm having the same issue. I've turned on all of the ecmaFeatures.

Based on having seen that #1543 wasn't picking up the rest args I was figuring this is probably an issue with escope. escope definitely supports imports

eslint's [email protected] uses [email protected] which does include es6-import

nzakas · 2015-03-09T01:28:46Z

Could be an escope issue, but also could be the rule itself. Need to investigate.

jasonkuhrt · 2015-03-09T12:44:31Z

I'm also seeing this.

Source:

import Promise from 'bluebird'
import { partial as par, compose, merge, waitForEvent } from 'lodash'
import shortid from 'shortid'
import Log from './log'
import JsonStream from 'json-stream2'



export default function DeviceConnection(socket) {

  socket.subscribers = {}

  socket.log = Log.child(socket.profile) // <--- ERROR no un-def for `Log`

λ cat .eslintrc
---
  env:
    node: true
    mocha: true
    browser: true
    es6: true
  ecmaFeatures:
    modules: true
  rules:
    no-underscore-dangle: false
    space-in-parens: "never"
    space-before-blocks: "always"
    space-in-brackets: "always"
    no-lonely-if: true
    default-case: true
    quotes: [1, "single", "avoid-escape"]
    strict: false
    no-use-before-define: "nofunc"
    camelcase: false
    new-cap: "newIsCap"
    curly: [2, "multi-line"]
    semi: [0, "always"]

fczuardi · 2015-03-09T13:29:39Z

the link sent by @AsaAyers is a good hint, the identifiers of an import are not expected to be on global scope (scopes[0]) https://github.com/estools/escope/blob/master/test/es6-import.coffee#L39 but on a separate one instead https://github.com/estools/escope/blob/master/test/es6-import.coffee#L42

The no-undef rule uses a context.getScope https://github.com/eslint/eslint/blob/master/lib/rules/no-undef.js#L99 that returns only scopes[0] https://github.com/eslint/eslint/blob/master/lib/eslint.js#L953 and the imported variable is not there because it is stored in a different object (with scopes type module).

The eslint-babel parser project is having this same bug babel/babel-eslint#15 here is one patch example of a fork that attempts to fix this: BenoitZugmeyer/babel-eslint@f9a84aa

xjamundx · 2015-03-09T17:36:55Z

Not yet helpful, but diving a bit into the getScope method I see the following when I log all of the scope types and variables for the following code.

import $ from 'jquery';
import BaseView from 'BaseView';
import NotifcationView from 'view/notification';

Here is the logging I added to the getScope() method:

currentScopes.forEach(function(scope) {
    console.log(scope.type, scope.variables.map(function(x) { return x.name; }), "\n");
});

Here is the result:

global [ 'Array',
  'ArrayBuffer',
  'Boolean',
  // ... all of the rest of the expected globals
 ] 
function [ 'arguments' ] 
module [] 
function [ 'arguments', 'loadError' ] 
block [ 'bodyData' ] 
block [] 
block [] 
function [ 'arguments' ] 
function [ 'arguments' ] 
function [ 'arguments', 'event' ]

So I'm not sure if we're getting what we need from escope (or I'm logging the wrong things...) I'd assume variables should exist inside of the module scope or something?

fczuardi · 2015-03-09T17:40:55Z

Here is a similar testcase to help understand the issue:

// install each tip of the branch with:
//     npm install jquery/esprima#harmony
//     npm install eslint/espree
//     npm install estools/escope
//     cd node_modules/escope && node_modules/.bin/gulp build && cd ../../

var esprima = require('esprima');
var espree = require('espree');
var escope = require('escope');

var code = 'import v from "mod"';

var esprimaConfig = {
    sourceType: 'module'
};

var espreeConfig = {
    ecmaFeatures: {
        modules: true
    }
};

var escopeConfig = {
    ecmaVersion: 6,
    sourceType: 'module'
};

var ast1 = esprima.parse(code, esprimaConfig);
var ast2 = espree.parse(code, esprimaConfig);
var ast3 = espree.parse(code, espreeConfig);

var scopeManager1 = escope.analyze(ast1, escopeConfig);
var scopeManager2 = escope.analyze(ast2, escopeConfig);
var scopeManager3 = escope.analyze(ast3, escopeConfig);

console.log('esprima harmony:', scopeManager1.scopes[1].variables);
console.log('eslint espree w/ esprima conf', scopeManager2.scopes[1].variables);
console.log('eslint espree:w/ espree conf', scopeManager3.scopes[1].variables);

Output:

esprima harmony: [ { name: 'v',
    identifiers: [ [Object] ],
    references: [],
    defs: [ [Object] ],
    tainted: false,
    stack: true,
    scope: 
     { type: 'module',
       set: {},
       taints: {},
       dynamic: false,
       block: [Object],
       through: [],
       variables: [Circular],
       references: [],
       variableScope: [Circular],
       functionExpressionScope: false,
       directCallToEvalScope: false,
       thisFound: false,
       __left: null,
       upper: [Object],
       isStrict: true,
       childScopes: [] } } ]
eslint espree w/ esprima conf []
eslint espree:w/ espree conf []

nzakas · 2015-03-09T18:18:08Z

This is an interesting discussion, but it should be taking place in an escope issue, not here.

It looks like escope hasn't been updated to respect the latest AST structure for modules.

fczuardi · 2015-03-09T18:19:56Z

is this the estools/escope#33 or a new unfilled one?

nzakas · 2015-03-09T18:55:46Z

Best to start a new one.

fczuardi · 2015-03-09T19:09:21Z

filed estools/escope#51

nzakas · 2015-03-09T19:18:49Z

Thanks!

ai · 2015-03-10T16:51:21Z

@fczuardi estools/escope#51 is fixed. does we need bugfix release for ESLint or i just need to update node_modules?

fczuardi · 2015-03-10T17:32:54Z

I don't know if that fix also fixes this one, need to test it, can you please try updating your node_modules/eslint/node_modules/escope to the tip of their master and see if it works please?

ai · 2015-03-10T17:59:57Z

@fczuardi seems like they didn’t release it yet.

Anyway there is same issue with fresh node_modules.

fczuardi · 2015-03-10T18:11:09Z

you don't need to wait for a release, you can always install tip of the master of any npm package with npm install githubuser/project in the case of escope, after downloading the master branch with npm install you will also have to run a build task to build their library, but it should be as simple as a npm install followed by node_modules/.bin/gulp build inside their module directory

ai · 2015-03-10T18:19:20Z

@fczuardi it is open soource project, so I can’t ask every contributor to has so difficult install process. Also I prefer to wait rather that create difficult script tasks in Travis CI.

ai · 2015-03-10T18:20:22Z

@fczuardi but @keithamus said that this fix is works for him.

ai · 2015-03-10T19:35:35Z

Fixed with latest escope 2.0.7 update

fczuardi · 2015-03-10T19:50:32Z

eslint still has 2.0.6 https://github.com/eslint/eslint/blob/master/package.json#L42 have you tested before closing the bug?

ai · 2015-03-10T19:53:08Z

2.0.7 is in ^2.0.6 dependency, becuase of ^. And I tested it in PostCSS project.

emmenko · 2015-03-10T19:53:17Z

@fczuardi since it's specified with caret ^ you can install eslint and the patch version of escope gets installed (no need to release a new version).

emmenko · 2015-03-10T20:00:59Z

PS: I can confirm it's working now! 👍

fczuardi · 2015-03-10T20:03:31Z

nice \o/

wavded · 2015-03-10T20:20:23Z

This resolved the undef issue, great work... unfortunately, now I'm getting this one... #1985

ivanoats · 2015-03-12T14:38:56Z

My work-around was to go into node_modules/eslint/ and edit package.json to require escope 2.0.7 then nom install [email protected] from there. This might have to be done in your global packages, too, for me it was /Users/ivan/.nvm/v0.10.36/lib/node_modules/eslint

AsaAyers · 2015-03-12T14:43:11Z

Upgrading to 2.0.7 broke other things whichis why it was not in the latest release: #2001

zpratt · 2015-03-12T14:54:56Z

I too am using the inline global variable whitelist as a temp workaround. Not ideal, but easy to remove once the issue is fixed.

nzakas · 2015-03-12T15:34:12Z

@emmenko we are waiting for a fix from escope, so you'll need to workaround this for now. When there is an update, it will be posted here.

emmenko · 2015-03-12T15:42:40Z

@nzakas perfect, many thanks! :)

nzakas · 2015-03-14T19:46:05Z

Going to see if I can workaround while waiting for escope.

Fix: module import specifiers should be defined (refs #1978)

wavded · 2015-03-15T02:22:07Z

Maybe this is in line with this issue, but using 0.17, given this code (with es6 env and modules turned on):

import auth from 'basic-auth'
var foo = {}
var creds = auth(foo)
foo.creds = {
  username: creds.name,
  password: creds.pass
}

Gives this error:

/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/rules/no-func-assign.js:42
                if (def.name.name === name && def.type === "FunctionName") {
                            ^
TypeError: Cannot read property 'name' of undefined
    at checkIfIdentifierIsFunction (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/rules/no-func-assign.js:42:29)
    at EventEmitter.AssignmentExpression (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/rules/no-func-assign.js:73:17)
    at emitOne (events.js:82:20)
    at EventEmitter.emit (events.js:166:7)
    at Controller.controller.traverse.enter (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/eslint.js:735:25)
    at Controller.__execute (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/node_modules/estraverse/estraverse.js:393:31)
    at Controller.traverse (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/node_modules/estraverse/estraverse.js:491:28)
    at EventEmitter.module.exports.api.verify (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/eslint.js:728:24)
    at processFile (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/cli-engine.js:193:27)
    at /Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/cli-engine.js:293:26

Another one is this code:

import auth from 'basic-auth'

Gives this error:

/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/rules/no-unused-vars.js:43
            if (definition.type === "VariableDeclarator") {
                          ^
TypeError: Cannot read property 'type' of undefined
    at isExported (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/rules/no-unused-vars.js:43:27)
    at EventEmitter.Program:exit (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/rules/no-unused-vars.js:120:70)
    at emitOne (events.js:82:20)
    at EventEmitter.emit (events.js:166:7)
    at Controller.controller.traverse.leave (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/eslint.js:743:25)
    at Controller.__execute (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/node_modules/estraverse/estraverse.js:393:31)
    at Controller.traverse (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/node_modules/estraverse/estraverse.js:481:28)
    at EventEmitter.module.exports.api.verify (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/eslint.js:728:24)
    at processFile (/Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/cli-engine.js:193:27)
    at /Users/wavded/.nvm/versions/io.js/v1.5.1/lib/node_modules/eslint/lib/cli-engine.js:293:26

nzakas · 2015-03-16T15:49:44Z

@wavded that's a completely separate issue, can you open a separate issue?

wavded · 2015-03-16T16:18:02Z

Sure thing. #2071

ai · 2015-03-28T20:27:22Z

Maybe I can help? 1.8 release and still not fix this issue (but we had some fix before)

nzakas · 2015-03-28T23:21:52Z

The "fix" from before resulted in regressions in other areas, which is why it was removed. The only real solution here is to get to the point where we can upgrade escope. To do that, the parser needs updating.

nzakas · 2015-04-11T19:26:58Z

Fixed by #2235

FrenchBen · 2015-08-03T17:15:07Z

Still having the same error 'Illegal import declaration (undefined)' in atom.io:
[email protected]
[email protected]
[email protected]

import _ from 'underscore';
import Promise from 'bluebird';

IanVS · 2015-08-03T17:32:43Z

@FrenchBen, what is your .eslintrc? You will need to specify ecmaFeatures: { modules: true } as mentioned in http://eslint.org/docs/user-guide/configuring#specifying-language-options

FrenchBen · 2015-08-03T17:45:48Z

@IanVS eslintrc is as follow:

root: true

ecmaFeatures:
    modules: true
    jsx: true
    arrowFunctions: true
    blockBindings: true

env:
    node: true
    es6: true
    browser: true

extends:
    "eslint:recommended"

then a bunch of rules... mostly taken from the eslintrc found in this repo

IanVS · 2015-08-03T17:48:00Z

Do you get the same error if you run eslint directly, outside of atom?

FrenchBen · 2015-08-03T17:53:23Z

It deosn't seem to complain about it - Guess the plugin/package for atom is to blame :[ ?
Package is: https://atom.io/packages/linter-eslint

IanVS · 2015-08-03T17:54:55Z

I'd suggest opening an issue there, if one does not already exist.

FrenchBen · 2015-08-03T17:56:13Z

will do - thanks for the quick response.

nzakas added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Mar 9, 2015

fczuardi mentioned this issue Mar 9, 2015

Add ECMAScript 6 features eslint/js#10

Closed

22 tasks

keithamus mentioned this issue Mar 10, 2015

change the referencer to support import as described in the ESTree spec (fixes #51) estools/escope#52

Merged

ai closed this as completed Mar 10, 2015

nzakas added the blocked This change can't be completed until another issue is resolved label Mar 14, 2015

nzakas added a commit that referenced this issue Mar 14, 2015

Fix: module import specifiers should be defined (refs #1978)

ceddc31

nzakas added a commit that referenced this issue Mar 14, 2015

Fix: module import specifiers should be defined (refs #1978)

e4c6b41

nzakas added a commit that referenced this issue Mar 14, 2015

Merge pull request #2035 from eslint/issue1978

5d35bc6

Fix: module import specifiers should be defined (refs #1978)

quicksnap mentioned this issue Mar 19, 2015

Question: ESLint with imports kriasoft/react-starter-kit#81

Closed

steida mentioned this issue Apr 10, 2015

eslint: Detect unused ES6 imports este/este#155

Closed

nzakas closed this as completed Apr 11, 2015

yannickcr mentioned this issue Apr 12, 2015

react-in-jsx-scope doesn't work with ES6 imports jsx-eslint/eslint-plugin-react#58

Closed

FrenchBen mentioned this issue Aug 3, 2015

Add lint-eslint support docker/kitematic#886

Merged

eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018

eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018

no-undef error on ES6 import #1978

no-undef error on ES6 import #1978

Comments

ai commented Mar 8, 2015

AsaAyers commented Mar 9, 2015

nzakas commented Mar 9, 2015

jasonkuhrt commented Mar 9, 2015

fczuardi commented Mar 9, 2015

xjamundx commented Mar 9, 2015

fczuardi commented Mar 9, 2015

nzakas commented Mar 9, 2015

fczuardi commented Mar 9, 2015

nzakas commented Mar 9, 2015

fczuardi commented Mar 9, 2015

nzakas commented Mar 9, 2015

ai commented Mar 10, 2015

fczuardi commented Mar 10, 2015

ai commented Mar 10, 2015

fczuardi commented Mar 10, 2015

ai commented Mar 10, 2015

ai commented Mar 10, 2015

ai commented Mar 10, 2015

fczuardi commented Mar 10, 2015

ai commented Mar 10, 2015

emmenko commented Mar 10, 2015

emmenko commented Mar 10, 2015

fczuardi commented Mar 10, 2015

wavded commented Mar 10, 2015

ivanoats commented Mar 12, 2015

AsaAyers commented Mar 12, 2015

zpratt commented Mar 12, 2015

nzakas commented Mar 12, 2015

emmenko commented Mar 12, 2015

nzakas commented Mar 14, 2015

wavded commented Mar 15, 2015

nzakas commented Mar 16, 2015

wavded commented Mar 16, 2015

ai commented Mar 28, 2015

nzakas commented Mar 28, 2015

nzakas commented Apr 11, 2015

FrenchBen commented Aug 3, 2015

IanVS commented Aug 3, 2015

FrenchBen commented Aug 3, 2015

IanVS commented Aug 3, 2015

FrenchBen commented Aug 3, 2015

IanVS commented Aug 3, 2015

FrenchBen commented Aug 3, 2015