Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐈 Task: Blacken code in CI/CD #1356

Closed
miquelduranfrigola opened this issue Oct 27, 2024 · 6 comments
Closed

🐈 Task: Blacken code in CI/CD #1356

miquelduranfrigola opened this issue Oct 27, 2024 · 6 comments

Comments

@miquelduranfrigola
Copy link
Member

Summary

All code in ersilia should be blackened (formatted) with the black tool.
I suggest that we do this in CI/CD. I am quite confident GitHub Actions exist to format code.

Objective(s)

  • Have well formatted code in Ersilia using black.
  • Do the formatting in GitHub Actions.

Documentation

N/A

@daud99
Copy link
Contributor

daud99 commented Oct 30, 2024

@DhanshreeA If you feel like I can look into this.

@DhanshreeA
Copy link
Member

I am also trying to look at: https://docs.astral.sh/ruff/ which is catching on quite a lot.

@DhanshreeA
Copy link
Member

The action plan is to incorporate ruff format in the pipeline, as well as look into using ruff check --fix in the codebase to fix several linting errors. We're considering ruff because it is many times faster than Black.

@daud99
Copy link
Contributor

daud99 commented Nov 19, 2024

@DhanshreeA Ruff sounds like a great choice, especially with the speed boost. Happy to help with the setup if needed!

@DhanshreeA DhanshreeA assigned DhanshreeA and unassigned DhanshreeA Dec 5, 2024
@GemmaTuron
Copy link
Member

Is this related to #1417 ?
Please let's avoid issue duplication.

@DhanshreeA
Copy link
Member

Is this related to #1417 ? Please let's avoid issue duplication.

Hi @GemmaTuron yes this is related. I am closing this issue because the other one has more features which we should ideally have.

@DhanshreeA DhanshreeA closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
@github-project-automation github-project-automation bot moved this from On Hold to Done in Ersilia Model Hub Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants