Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📑 Feature Request: Extensions for updated test script #1228

Open
kurysauce opened this issue Aug 15, 2024 · 12 comments
Open

📑 Feature Request: Extensions for updated test script #1228

kurysauce opened this issue Aug 15, 2024 · 12 comments
Labels
enhancement New feature or request on-hold Interesting issue that we deprioritize

Comments

@kurysauce
Copy link
Contributor

kurysauce commented Aug 15, 2024

Describe your feature request.

After developing the updated test.py command for Ersilia #1203 , I believe having a detailed report for model contributors and users would be helpful in debugging and understanding the models in context.

The testing report summary, along with including the metrics measured in the test.py command should also include the following (not an exhaustive list):

  • Inuputs that were tested, inputs that raised specific errors
  • Software Dependencies: List of all libraries and tools used, including versions
    • Espeically helpful if users want to run and download the models locally
    • Warnings if models don't work on certain operating systems (MacOS, Windows, etc...)
  • Performance Tests:
    • metrics such as speed, memory usage
  • Output checks, If errors are raised or ouputs are invalid, describe them in context:
    • Missing Values
    • Outliers
    • Formatting Errors
@kurysauce
Copy link
Contributor Author

  • Support the method check_consistent_output with checking more Output Shape types (as mentioned on the Ersilia Model Template Book)
    • Current type check supported are Single,List. Needs support for Flexible List, Matrix, Serializable Object
    • From a meeting with @miquelduranfrigola , we need to incorporate models that support this output shape type

@miquelduranfrigola
Copy link
Member

Thanks @kurysauce
@DhanshreeA to bring you up to speed, this is not something we need to tackle immediately but it is a nice feature request from @kurysauce . Let's leave it in out to-do list for now.

@kurysauce
Copy link
Contributor Author

Update check_consistent_output and comparison between bash & Ersilia run in run_bash methods to allow comparisons for data structure containing different output types. Current method only supports comparisons between outputs that are all numerical values and all strings.

@miquelduranfrigola
Copy link
Member

This makes sense. Thanks @kurysauce

@GemmaTuron GemmaTuron added the on-hold Interesting issue that we deprioritize label Sep 19, 2024
@GemmaTuron
Copy link
Member

Hi @DhanshreeA and @miquelduranfrigola

I am marking this as "on-hold" until we have a clear roadmap for Ersilia CLI commands

@GemmaTuron GemmaTuron moved this to On Hold in Ersilia Model Hub Sep 24, 2024
@GemmaTuron
Copy link
Member

Hi @DhanshreeA

@Abellegese has been working on the test script right? so is this on hold still or undergoing? If so, which issues from the original list have been tackled? Thanks

@Abellegese
Copy link
Contributor

Yes @GemmaTuron this addressed in depth in new test pipeline including the playground.

Currently it does not give list of packages with version. Thats only it, if its important will update to do that.

@GemmaTuron
Copy link
Member

Hi @Abellegese

Thanks, please give more details and/or a link to the documentation before we can close this issue. I need more info to understand the pipeline.

@Abellegese
Copy link
Contributor

Abellegese commented Dec 17, 2024

Hi @GemmaTuron yes I have a doc for playground. For model tester, I will upload it and let you know.

@Abellegese
Copy link
Contributor

I do have the docs, revise a bit and upload it to gitbook.

@Abellegese
Copy link
Contributor

Abellegese commented Dec 27, 2024

So this issue also has been addressed in the following cases:

  1. Pytest for five ersilia CLI and all the associated function level testing using partial mocking.
  2. Playground test: to test model behaviour using custom rules
  3. Model Tester: To test and remote and local models

@Abellegese
Copy link
Contributor

Hi @GemmaTuron the docs for model tester has been uploaded. You may check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on-hold Interesting issue that we deprioritize
Projects
Status: On Hold
Development

No branches or pull requests

4 participants