Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The quality of Cached image is very poor on Mac Book Pro with Retina display. #750

Open
kzhdev opened this issue Jan 15, 2014 · 8 comments · May be fixed by #792
Open

The quality of Cached image is very poor on Mac Book Pro with Retina display. #750

kzhdev opened this issue Jan 15, 2014 · 8 comments · May be fixed by #792
Assignees
Labels

Comments

@kzhdev
Copy link
Contributor

kzhdev commented Jan 15, 2014

It's only an issue on high resolution display which have pixelRatio > 1, like Mac Book Pro with retina display. I believe this was caused by pixelRatio: 1 in cacheCanvas.

You see this in this jsFiddle:
http://jsfiddle.net/kzhdev/43tfG/8/

@ericdrowell
Copy link
Owner

shoot I thought this was handled. I'll add this to the 5.0.1 release which is a patch coming out soon

Thanks!

@ghost ghost assigned ericdrowell Jan 15, 2014
kzhdev pushed a commit to kzhdev/KineticJS that referenced this issue Feb 3, 2014
kzhdev pushed a commit to kzhdev/KineticJS that referenced this issue Feb 3, 2014
@confile
Copy link

confile commented Apr 17, 2014

@ericdrowell is this issuce still open. Since you clain it is fixed in 5.0.1 and now 5.1.0 is released?

@kzhdev
Copy link
Contributor Author

kzhdev commented Apr 27, 2014

The problem is still there. Actually, 5.1.0 is worse, not just the cashed image, the quality of non-cached shape is bad too.

@kzhdev
Copy link
Contributor Author

kzhdev commented Apr 27, 2014

Set the pixelRatio to 1 for desktops is really bad. It made everything blur in high resolution computers, like Mac Book Pro with Retina display. Here is the comments:

    As of 02/26/2014, there doesn't seem to be a way
    // to reliably calculate the browser zoom for modern browsers, which is why we just set
    // the pixel ratio to 1 for desktops

I don't know why you care browser zoom? Browser zoom wouldn't matter, it apply after the canvas drawing.

@lavrton
Copy link
Contributor

lavrton commented Apr 27, 2014

Are you sure that quality of non-cached shapes is bad? Everything is good for me. (tested on iPad)

@confile
Copy link

confile commented Apr 27, 2014

I have the same problem. The quality is very bad. The the worst quality is when I downscale an image.

@kzhdev
Copy link
Contributor Author

kzhdev commented Apr 28, 2014

100% sure.
Here is the image in 5.1.0, left side is non-cached shape, right side is cached shape.
http://jsfiddle.net/kzhdev/43tfG/18/

This is the original in 5.0.1
http://jsfiddle.net/kzhdev/43tfG/8/

This is my fix:
http://jsfiddle.net/kzhdev/43tfG/17/

@kzhdev
Copy link
Contributor Author

kzhdev commented Apr 28, 2014

On iPad is OK because it was on mobile, its pixelRatio is 2. On desktop, like Mac Book with Retina display, the pixelRation is 1, that bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants