Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Current implementation of auto-tune switch doesn't work correctly #822

Open
sectroyer opened this issue Mar 11, 2023 · 1 comment
Open
Labels
bug Something isn't working confirmed pinned

Comments

@sectroyer
Copy link

Describe the bug
I tried running a scan with auto-tune switch on a target that allows maximum of 300 req/s. With auto-tune feroxbuster was trying to do almost 4k req/s. As a result it was receiving tons of 429 and still decided it's good idea to "increase speed" I let it run for around 30 seconds (to not overburden the target ) but speed kept on oscillating around 3.5k req/s. At the same I had no way to "hint" the app about max rate as --rate-limit option doesn't work with --auto-tune. I attach a screen shot of my scan.
Zrzut ekranu 2023-03-11 o 15 14 40

@sectroyer sectroyer added the bug Something isn't working label Mar 11, 2023
@epi052
Copy link
Owner

epi052 commented Mar 12, 2023

i recently reworked the auto-tune logic so that it's more aggressive about returning to a faster speed. It'll check every --timeout / 2 seconds whether the # of 429s/errors has increased or not and adjust based off that. auto-tune always tries to work itself back to an unlimited scan, which may not be the best solution. It doesn't have the concept of 'locking in' a rate (i.e. 300 req/s).

as a test, you could also try a longer span between rate adjustments by increasing the timeout, to see how it affects behavior. it would give it more time to 'see' the additional 429s

currently, --auto-tune and --rate-limit are mutually exclusive. would being able to use --rate-limit as a maximum value for --auto-tune address your issue?

ref: https://epi052.github.io/feroxbuster-docs/docs/examples/auto-tune/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed pinned
Projects
None yet
Development

No branches or pull requests

2 participants