Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No Magic Strings" for Event names #361

Open
mixmix opened this issue May 29, 2024 · 1 comment
Open

"No Magic Strings" for Event names #361

mixmix opened this issue May 29, 2024 · 1 comment
Assignees
@frankiebee
Labels
keyring

Comments

@mixmix
Copy link
Collaborator

mixmix commented May 29, 2024

If we're using event emitters in keyring:

  • make one events.js file, put all the events in there
  • import named events
  • document the events in that file?
  • feel bad when that file gets too big
@mixmix
Copy link
Collaborator Author

mixmix commented May 29, 2024 •
edited
Loading

e.g.

export const ACCOUNT_UPDATE = 'account-update'
/* this is emitted when.... */
export const ACCOUNT_CREATE = 'account-create'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankiebee frankiebee

Labels
keyring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mixmix @frankiebee