Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent Key Value #931

Closed
JesseAbram opened this issue Jul 11, 2024 · 0 comments · Fixed by #933
Closed

Parent Key Value #931

JesseAbram opened this issue Jul 11, 2024 · 0 comments · Fixed by #933

Comments

@JesseAbram
Copy link
Member

In #918 the network creates a parent key and currently uses the 0x00 address

However in ed25519 and sr25519 that is an insecure account, actions on the address are blocked anyways, however there could be potential secondary effects we are not aware of (probably not but still why tempt fate)

The shard can sit under any key value in the kvdb and having it known actually helps, changing it to "NETWORK_PARENT_KEY" seems to make sense

This was referenced Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant