Group named "data" causes Pyxform error about duplicate sections

[pbowen-oc]

If I try to convert a form that has a group named "data", I get the following response:
Error: There are two sections with the name data.

Test form: Data1 version 2.zip

I am assuming this is due to Pyxform setting the root node as data now instead of using the XLS filename.

Is this error really intended? If so, can the message for this case be changed to something more suitable - i.e., indicating "data" is a reserved word and cannot be used for a group/repeating group name rather than telling the user there is a duplicate (that they can't see)? If this error can be avoided, that would be preferred since we already have forms with groups named data.

I noticed that having an item named data does not cause any errors in Pyxform or Validate. Is it safe to use that as an item name?

[MartijnR]

I don't think data is handled any differently as any other duplicate nodeName, but we can definitely do that.
Any old forms that use data but don't have that root node name, should not get any error message.

• if duplicate node error is due to data being root, change to a more helpful message
• look into question named data (and root node name data)

It's definitely safest to avoid duplicates because Enketo has been optimized knowing that pyxform has that rule. However, I think a single question named data (and a root named data) may be an acceptable risk though.

[MartijnR]

• check whether pyxform or ODK Validate flags this - pyxform
• file an issue if pyxform (probably don't if ODK Validate?) - Proposal to change duplicate section name error message if equal to root node name XLSForm/pyxform#510
• check behavior of Enketo Validate and adjust if necessary - no problem as it ignores root node for this check
• fix bug in repeat determination for sibling nodes with same name